Feat: `move_item_from_lista_to_listb/4` function for moving `items` between `lists`

[nelsonic]

To aid with _moving _an item from one list to another, we need a little function.

Todo

• Create the tests: item.cid should be removed from lista and added to listb. 🧪
• Write the function. 🧑‍💻
• Ship!!

Note: this only applies if the list is not "All" which we should not remove items from;
That's the whole point of the "All" list ...

Thankfully we already have two helper functions we can call for this:

mvp/lib/app/list.ex

Lines 171 to 176 in 15af0f1

	def add_item_to_list(item_cid, list_cid, person_id) do
	list = get_list_by_cid!(list_cid)
	prev_seq = get_list_seq(list)
	seq = [item_cid | prev_seq] |> Enum.join(",")
	update_list(list, %{seq: seq, person_id: person_id})
	end

and:

mvp/lib/app/list.ex

Lines 189 to 199 in 15af0f1

	def remove_item_from_list(item_cid, list_cid, person_id) do
	list = get_list_by_cid!(list_cid)
	# get existing list.seq
	seq =
	get_list_seq(list)
	# remove the item_cid from the list.seq:
	|> Useful.remove_item_from_list(item_cid)
	|> Enum.join(",")
	update_list(list, %{seq: seq, person_id: person_id})
	end

So this should be relatively straightforward. 💭

[nelsonic]

This is the function:

  def move_item_from_lista_to_listb(item_cid, lista_cid, listb_cid, person_id) do
    # Remove from List A:
    remove_item_from_list(item_cid, lista_cid, person_id)
    # Add to List B:
    add_item_to_list(item_cid, listb_cid, person_id)
  end

Like I said above, it's simple. Because we already had the two precursor functions thanks to #422

But I'm now thinking that from an Interface perspective what we actually want to do is update the whole list.seq from the client so that we preserve the sequence of the items ... 💭

[nelsonic]

Included in #165
If we decide not to use it, easy to remove. 👌