Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Lists to Main Menu #424

Closed
2 tasks done
Tracked by #165
nelsonic opened this issue Sep 15, 2023 · 5 comments
Closed
2 tasks done
Tracked by #165

Feat: Add Lists to Main Menu #424

nelsonic opened this issue Sep 15, 2023 · 5 comments
Assignees
Labels
elixir Pull requests that update Elixir code priority-1 Highest priority issue. This is costing us money every minute that passes. T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 15, 2023

At present there is no way to navigate to a list from the Main Menu:

main-menu-no-lists

Todo

  • iterate over the person's lists and display them in the main menu
  • Hyperlink to the /?list_cid=:list_cid

Note: the route for the /lists on the #165 PR is currently:

resources "/lists", ListController, except: [:show]

The except: [:show] part means we don't yet have an interface for displaying the list.
So we need that part too ... 💭 ref: #423

@nelsonic nelsonic added technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-1 Highest priority issue. This is costing us money every minute that passes. T1h Time Estimate 1 Hour elixir Pull requests that update Elixir code labels Sep 15, 2023
@nelsonic nelsonic self-assigned this Sep 15, 2023
@nelsonic nelsonic mentioned this issue Sep 16, 2023
10 tasks
@nelsonic
Copy link
Member Author

nelsonic commented Oct 30, 2023

Trying to work on this. But after splitting out the <nav> into its' own component, the CSS/JS is not working to hide the menu items:

image

Each time I try and look at the code one of the delightful children needs my attention. ❤️ ⏳ 🙄

@nelsonic
Copy link
Member Author

nelsonic commented Nov 1, 2023

With @LuchoTurtle's help pairing on this we figured out that the id="mobile-menu" was not required in the menu items

<div x-show="openMenu" id="mobile-menu">
<div class="space-y-1 px-2 pb-3 pt-2 text-right">
<!-- <a href="#" class="bg-gray-900 text-white rounded-md px-3 py-2 text-sm font-medium" aria-current="page">Current</a> -->
<%= link("📥 All",
to: "/tags",
class:
"text-gray-300 hover:bg-gray-700 hover:text-white rounded-md px-3 py-2 text-sm font-medium"
) %>
</div>
</div>
<div x-show="openMenu" id="mobile-menu">
and removing the (duplicate) id made it all work. 🎉

@nelsonic
Copy link
Member Author

nelsonic commented Nov 1, 2023

lists dynamically rendered in the main menu:

image

:shipit:

@nelsonic
Copy link
Member Author

nelsonic commented Nov 1, 2023

With a bit more contrast and differentiation between the person's lists and the other pages:

image

Not going to mess any further with this. 👌
Very happy for anyone else to improve this. 🙏

@nelsonic
Copy link
Member Author

nelsonic commented Nov 1, 2023

Included in #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code priority-1 Highest priority issue. This is costing us money every minute that passes. T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Status: Done
Status: Done
Development

No branches or pull requests

1 participant