Skip to content

Commit 8cfbf03

Browse files
authored
Resolve Proto Lint Issues (prysmaticlabs#3044)
* skip proto lint * golang ci lint no -t flag * regenerate protos to match schema * move to compatibility folder * build file compatibility * foo
1 parent d5dcc25 commit 8cfbf03

File tree

10 files changed

+390
-150
lines changed

10 files changed

+390
-150
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ matrix:
1212
- go get ${gobuild_args} -t ./...
1313
- go get ${gobuild_args} github.com/golangci/golangci-lint/cmd/golangci-lint
1414
script:
15-
- golangci-lint run
15+
- golangci-lint run --skip-dirs ./proto
1616
email: false
1717
after_success:
1818
- wget https://raw.githubusercontent.com/k3rn31p4nic/travis-ci-discord-webhook/master/send.sh

proto/beacon/p2p/v1/messages.pb.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/beacon/p2p/v1/types.pb.go

+93-93
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/beacon/rpc/v1/services.pb.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/eth/v1alpha1/BUILD.bazel

-11
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,6 @@ proto_library(
2020
],
2121
)
2222

23-
go_test(
24-
name = "go_default_test",
25-
size = "small",
26-
srcs = ["compatability_test.go"],
27-
deps = [
28-
":go_default_library",
29-
"@com_github_gogo_protobuf//proto:go_default_library",
30-
"@com_github_prysmaticlabs_ethereumapis//eth/v1alpha1:go_default_library",
31-
],
32-
)
33-
3423
go_proto_library(
3524
name = "go_default_library",
3625
compiler = "//:grpc_proto_compiler",
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
load("@io_bazel_rules_go//go:def.bzl", "go_test")
2+
3+
go_test(
4+
name = "go_default_test",
5+
srcs = ["compatability_test.go"],
6+
deps = [
7+
"//proto/eth/v1alpha1:go_default_library",
8+
"@com_github_gogo_protobuf//proto:go_default_library",
9+
"@com_github_prysmaticlabs_ethereumapis//eth/v1alpha1:go_default_library",
10+
],
11+
)

proto/eth/v1alpha1/beacon_chain.pb.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)