[jan] Fix deprecation warnings about each() with PHP 7.2+.

Author: Jan Schneider

docs/changelog.yml

@@ -71,8 +71,9 @@
   license:
     identifier: GPL-2.0
     uri: http://www.horde.org/licenses/gpl
-  notes: |+
-    
+  notes: |
+    [jan] Fix deprecation warnings about each() with PHP 7.2+.
+    |+
 6.2.27:
   api: 6.2.0
   state:

lib/Ajax/Application/ListMessages.php

@@ -434,8 +434,7 @@ private function _getOverviewData($mbox, $msglist)
         ));
 
         /* Display message information. */
-        reset($overview['overview']);
-        while (list(,$ob) = each($overview['overview'])) {
+        foreach ($overview['overview'] as $ob) {
             /* Get all the flag information. */
             $msg = array(
                 'flag' => $flags

lib/Basic/Mailbox.php

@@ -843,7 +843,7 @@ protected function _init()
         $search_view = clone $view;
         $summary_view = clone $view;
 
-        while (list(,$ob) = each($mbox_info['overview'])) {
+        foreach ($mbox_info['overview'] as $ob) {
             if ($search_mbox) {
                 if (empty($lastMbox) || ($ob['mailbox'] != $lastMbox)) {
                     if (!empty($lastMbox)) {

lib/Contents.php

@@ -1480,8 +1480,7 @@ public function getInlineOutput(array $options = array())
                 continue;
             }
 
-            reset($render_part);
-            while (list($id, $info) = each($render_part)) {
+            foreach ($render_part as $id => $info) {
                 $display_ids[$id] = 1;
 
                 if (empty($info)) {
@@ -1534,8 +1533,7 @@ public function getInlineOutput(array $options = array())
             uksort($msgtext, 'strnatcmp');
         }
 
-        reset($msgtext);
-        while (list($id, $part) = each($msgtext)) {
+        foreach ($msgtext as $id => $part) {
             while (!empty($wrap_ids) &&
                    !Horde_Mime::isChild(end($wrap_ids), $id)) {
                 array_pop($wrap_ids);

lib/Mailbox/List/Virtual.php

@@ -94,8 +94,7 @@ public function getIndicesOb()
         $this->_buildMailbox();
         $ob = new IMP_Indices();
 
-        reset($this->_sorted);
-        while (list($k, $v) = each($this->_sorted)) {
+        foreach ($this->_sorted as $k => $v) {
             $ob->add($this->_sortedMbox[$k], $v);
         }
 

lib/Mime/Viewer/Plain.php

@@ -277,8 +277,7 @@ protected function _parseUUencode()
         $text_part->setContents(preg_replace("/begin [0-7]{3} .+\r?\n.+\r?\nend/Us", "\n", $text));
         $new_part->addPart($text_part);
 
-        reset($files);
-        while (list(,$file) = each($files)) {
+        foreach ($files as $file) {
             $uupart = new Horde_Mime_Part();
             $uupart->setType('application/octet-stream');
             $uupart->setContents($file['data']);

lib/Minimal/Mailbox.php

@@ -123,7 +123,7 @@ protected function _init()
         $mbox_info = $imp_mailbox->getMailboxArray(range($pageOb['begin'], $pageOb['end']), array('headers' => true));
         $msgs = array();
 
-        while (list(,$ob) = each($mbox_info['overview'])) {
+        foreach ($mbox_info['overview'] as $ob) {
             /* Initialize the header fields. */
             $msg = array(
                 'buid' => $imp_mailbox->getBuid($ob['mailbox'], $ob['uid']),