Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Warning popup when duplicate destination URL exists #926

Open
steven-tey opened this issue May 28, 2024 · 37 comments
Open

[FEAT]: Warning popup when duplicate destination URL exists #926

steven-tey opened this issue May 28, 2024 · 37 comments
Assignees
@01vishu

Comments

@steven-tey
Copy link
Collaborator

steven-tey commented May 28, 2024 •
edited
Loading

Via a user request:

We have a very distributed, remote, volunteer team, and we're trying to more consistently enforce using shortened links so we have better click tracking, but sometimes team members will go in to create a link for something that already has a link, not knowing that it exists. We'd love to have the option to enable a warning popup if the Destination URL specified when creating a new link already exists in another Short Link.

Implementation: Create a new endpoint that checks if a given destination URL exists in a workspace.

Bonus: Nail down the UI implementation for this – use AnimatedSizeContainer for a smooth transition. See Linear's "similar issues" UX for reference
@linear Linear
Copy link

linear bot commented May 28, 2024

ENG-337 [FEAT]: Warning popup when duplicate destination URL exists

@kasipavankumar
Copy link

I'd be happy to work on this.

One question to understand the requirements better:

  • Do we need to normalise the destination URLs before running the checks?
    • For example: https://www.google.com & https://google.com - should these both be considered the same destination URL?

kasipavankumar added a commit to kasipavankumar/dub that referenced this issue Jun 1, 2024
@kasipavankumar
Show warning when duplicate destination URL exists (dubinc#926)
03324db
@kasipavankumar kasipavankumar mentioned this issue Jun 1, 2024
Closed
@kasipavankumar
Copy link

I've opened a PR #945. Please review, @steven-tey.

@01vishu
Copy link
Contributor

01vishu commented Oct 7, 2024

/assign

@oss-gg oss-gg bot assigned 01vishu Oct 7, 2024
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 7, 2024

Assigned to @01vishu! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@kasipavankumar
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 7, 2024

This issue is already assigned to another person. Please find more issues here.

@Pranavtej
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 7, 2024

This issue is already assigned to another person. Please find more issues here.

@01vishu 01vishu mentioned this issue Oct 9, 2024
Closed
@manasCodes13
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@sour2001
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@yashthakare93
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@RudrakshDev
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@arpan595jain
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@AndrewHamal
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@rohan-choudharyy
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@TechWithAkash
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@kunalarya873
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 13, 2024

This issue is already assigned to another person. Please find more issues here.

@vamus092
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 14, 2024

This issue is already assigned to another person. Please find more issues here.

@skushagra9
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 14, 2024

This issue is already assigned to another person. Please find more issues here.

@Taranv8
Copy link

Taranv8 commented Oct 15, 2024

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 15, 2024

This issue is already assigned to another person. Please find more issues here.

@Zzzzssssss
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 15, 2024

This issue is already assigned to another person. Please find more issues here.

@mihirks
Copy link

mihirks commented Oct 15, 2024

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 15, 2024

This issue is already assigned to another person. Please find more issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@01vishu 01vishu

Labels
None yet
Projects
None yet
Milestone
No milestone