-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail gracefully when $this->appDir./sites not found #19
Comments
Pull request created #20 Catches core |
@JParkinson1991 Do you have a case where the folder Just asking because I never saw this case. |
@jkribeiro I tend to usually framework my Drupal stacks manually, so i dont use the When im building my project i like to test that all scaffolding and paranoia etc is working before i start adding in sites, so in early stages of project builds i dont have a sites folder whilst im testing this plugin along with the Running this plugin without a sites directory is an edge case that probably wont affect many users for sure. But i do think it should be handled and not cause this plugin to break. |
During installation of this package, during early site builds where the 'sites' directory does not exist under
$this->appDir/sites
anInvalidArgumentException
or aDirectoryNotFoundException
will be thrown by the Symfony Finder package.This can cause failed installations and also causes the
drupal:paranoia
command to fail.These exceptions should be caught by the
Installer
and handled gracefully.It is safe to assumes public files directories do not exist under
$this->appDir
if thesites
directory is not found.Expected behavior
Failing gracefully without attempting to link the non existent directories.
Actual behavior
Uncaught exception breaking package installation, plugin events and the provided commands.
Steps to reproduce
During install
app-dir
drupal-composer/drupal-paranoia
When running as a command
app-dir
drupal-composer/drupal-paranoia
composer drupal:paranoia
Possible solution
#20
The text was updated successfully, but these errors were encountered: