Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support changing default port #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support changing default port #37

wants to merge 1 commit into from

Conversation

rtoma
Copy link

@rtoma rtoma commented Feb 2, 2021

Fix for #12

@rtoma
Copy link
Author

rtoma commented Feb 2, 2021

Unsure how to resolve failed check. Drone logs show: Error: Error linting charts: Error processing charts - not much to go on.

@tokyowizard
Copy link

Try bumping up the version of chart-testing in the .drone.yml file. For example:

# git diff -- .drone.yml
diff --git a/.drone.yml b/.drone.yml
index fb06b93..047a8b0 100644
--- a/.drone.yml
+++ b/.drone.yml
@@ -4,7 +4,7 @@ name: default

 steps:
 - name: lint
-  image: quay.io/helmpack/chart-testing:v3.0.0-beta.1
+  image: quay.io/helmpack/chart-testing:v3.3.1
   commands:
   - apk add --update make
   - make lint

The output is more informative in this version.

# make lint
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 drone => (version: "0.1.7", path: "charts/drone")
------------------------------------------------------------------------------------------------------------------------

"bitnami" already exists with the same configuration, skipping
"stable" already exists with the same configuration, skipping
Linting chart 'drone => (version: "0.1.7", path: "charts/drone")'
Checking chart 'drone => (version: "0.1.7", path: "charts/drone")' for a version bump...
Old chart version: 0.1.7
New chart version: 0.1.7
------------------------------------------------------------------------------------------------------------------------
 ✖︎ drone => (version: "0.1.7", path: "charts/drone") > Chart version not ok. Needs a version bump!
------------------------------------------------------------------------------------------------------------------------
Error: Error linting charts: Error processing charts
Error linting charts: Error processing charts
make: *** [Makefile:5: lint] Error 1
#

cognifloyd added a commit to cognifloyd/drone-charts that referenced this pull request Sep 2, 2021
@cognifloyd
Merge upstream PR drone#37
2cc0824
@jimsheldon jimsheldon mentioned this pull request May 2, 2022
Closed
@jimsheldon
Copy link
Contributor

Apologies for the delay on this.

Changes have been pushed to master that should fix the build failure, can you rebase? Thanks

@jimsheldon jimsheldon added the enhancement New feature or request label May 2, 2022
@jimsheldon jimsheldon mentioned this pull request Oct 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtoma @tokyowizard @jimsheldon