Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make private chat tabs not change height of chat #1375

Open
vipperz opened this issue Oct 2, 2024 · 7 comments
Open

Make private chat tabs not change height of chat #1375

vipperz opened this issue Oct 2, 2024 · 7 comments
Labels
feature New features or improvements to existing ones

Comments

@vipperz
Copy link

vipperz commented Oct 2, 2024

I don't remember it doing this before, but if you would still have a private message tab in a session window and open another window from the same one (using New/ Open.../ Open recent/ Join session), the chat will stay the same size as if the private message is still there.

I'm not sure when this started happening in the Continuous Release, but it's gotten more noticeable since I keep the chat at minimal height.

@askmeaboutlo0m askmeaboutlo0m added the needs info Issue is stalled waiting for more information label Oct 2, 2024
@askmeaboutlo0m
Copy link
Member

The chat remembers its height and if you open a new window, it will continue to have that height. That doesn't have anything to do with the tabs inside of the chat.

Is the issue that the tabs make the chat higher? They do need a bit of extra space, so they expand the chat height if necessary.

@vipperz
Copy link
Author

vipperz commented Oct 2, 2024

Yes, it makes it higher, but the size of docks and chat wouldn't remember height/width until a Drawpile window was closed and re-opening a new window right after.

Having to close the private message for the chat to stay the original size in a new window wasn't needed until updating the Continuous Release, at some point.

@askmeaboutlo0m
Copy link
Member

If it didn't remember the height before, that was a bug. It's supposed to write the main window configuration when opening a new one.

That the chat changes size with tabs appearing and disappearing is mildly annoying though, so making that work differently could be implemented and would solve the issue.

@askmeaboutlo0m askmeaboutlo0m changed the title Chat transfers private message height to new window Make private chat tabs not change height of chat Oct 2, 2024
@askmeaboutlo0m askmeaboutlo0m added feature New features or improvements to existing ones and removed needs info Issue is stalled waiting for more information labels Oct 2, 2024
@vipperz
Copy link
Author

vipperz commented Oct 2, 2024

Oh, if it were a bug, it's what I've gotten used to over the years without much thought. Having the chat unchangeable in a way would be so nice, though.

Side note: If someone where to have two or more windows open - changing brush settings, adding new colors to a palette group, etc. in one - and doesn't close the changed window last, the changes get lost or not applied.

I'm not sure if this is considered a bug too or it's implied to happen, because it can be frustrating when you realize you didn't close that specific session last.

@askmeaboutlo0m
Copy link
Member

It's definitely undesirable behavior, but a pretty hard problem. Synchronizing everything between the windows leads to other undesirable behavior, like docks changing position, brushes being changed from under you etc. So it would really need a complete overhaul of the settings to figure out what should be synchronized and what should be per-window.

@MorrowShore
Copy link
Member

Will the chat system redesign not solve these issues on its own?

@askmeaboutlo0m
Copy link
Member

Depends on how chat tabs are implemented for it. If they use a regular Qt tab bar, it springing into existence would change the minimum height of the widget it's part of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or improvements to existing ones
Projects
None yet
Development

No branches or pull requests

4 participants
@askmeaboutlo0m @vipperz @MorrowShore and others