Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Wand Tool Overhaul #1327

Closed
MorrowShore opened this issue Jul 13, 2024 · 1 comment
Closed

Magic Wand Tool Overhaul #1327

MorrowShore opened this issue Jul 13, 2024 · 1 comment
Labels
feature New features or improvements to existing ones

Comments

@MorrowShore
Copy link
Member

MorrowShore commented Jul 13, 2024

Magic wand could use a series of adjustments to become a better tool.

A- Defaults:

A1- Default tolerance should be 22~26
A2- Default feather should be 1px
A3- Size limit default should be the entire canvas / disabled

B- Behavior

B1- Modifier keys + mouse scroll could be used to adjust parameters (such as size limit, if A3 is opposed)
B2- There should be an option to disable confirmation prompt for Magic Wand and fill tool, or alternatively, allow addition, reduction, manipulation, and inversion of the confirmation prompt itself (before confirming) which would practically be the same.
B3- Magic wand {left click, hold, and drag to left or right} should adjust tolerance in real time by units of 2 and update selection.
Animation4
B4- The selection demonstration during confirmation prompt should not have a popular color such as blue, but should instead be assuredly distinguishable from the image.

C- Performance

Considerations to improve magic wand performance are being made.

@MorrowShore MorrowShore added feature New features or improvements to existing ones hard Issues that are very difficult to solve labels Jul 13, 2024
@askmeaboutlo0m askmeaboutlo0m removed the hard Issues that are very difficult to solve label Nov 1, 2024
askmeaboutlo0m added a commit that referenced this issue Nov 1, 2024
Similar to how the magic wand tool works in GIMP, clicking and dragging
left and right will temporarily adjust the tolerance and show a preview
of the effect thereof.

Note that this is not how the fill tool works in GIMP, that just seems
to have bogus behavior there when you drag it.

Implements #1327.
@askmeaboutlo0m
Copy link
Member

A1 and A2 are arbitrary values that wouldn't be useful for many applications, like trying to select inside linework or for hard-edged lines. Leaving them at zero and letting the user adjust them makes more sense rather than leaving them scratching their head at which of the six sliders is making the borders blurry by default.

A3 is implemented.

B1 is a matter of canvas shortcuts and is already possible for the size limit. B2 and B3 are implemented. B4 is split off into #1396.

C is implemented.

@github-project-automation github-project-automation bot moved this from Todo to Merged in Selections Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or improvements to existing ones
Projects
Status: Merged
Development

No branches or pull requests

2 participants