From b17ba09f735c07b458896daf9dad2162f32f1c95 Mon Sep 17 00:00:00 2001
From: askmeaboutloom <askmeaboutlo0m@users.noreply.github.com>
Date: Sun, 17 Nov 2024 19:03:24 +0100
Subject: [PATCH] Remove superfluous permissions on Android

Camera, microphone and legacy external storage permission depending on
the Android version.

Fixes #1405.
---
 ChangeLog                          |  1 +
 src/desktop/AndroidManifest.xml.in | 14 ++++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2f54470d93..f04da28671 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -7,6 +7,7 @@ Unreleased Version 2.2.2-pre
  * Fix: Don't use bilinear interpolation in transforms unnecessarily.
  * Feature: Add canvas shortcuts for changing color hue, saturation/chroma and value/lightness/luminosity. Thanks Dann DecCairns for suggesting.
  * Feature: Make size adjustment canvas shortcut depend on the speed of the drag. Thanks MorrowShore for suggesting.
+ * Fix: Remove pointless permissions on Android that Qt includes by default but aren't actually used.
 
 2024-11-06 Version 2.2.2-beta.4
  * Fix: Solve rendering glitches with selection outlines that happen on some systems. Thanks xxxx for reporting.
diff --git a/src/desktop/AndroidManifest.xml.in b/src/desktop/AndroidManifest.xml.in
index bb08b9b5ea..328f061ef9 100644
--- a/src/desktop/AndroidManifest.xml.in
+++ b/src/desktop/AndroidManifest.xml.in
@@ -1,13 +1,23 @@
 <?xml version="1.0"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+<manifest
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     package="${ANDROID_PACKAGE_NAMESPACE}"
     android:installLocation="auto"
     android:versionCode="${DRAWPILE_ANDROID_VERSION_CODE}"
     android:versionName="${PROJECT_VERSION}">
-    <!-- %%INSERT_PERMISSIONS -->
+    <!-- INTERNET is required to open TCP connections. -->
+    <uses-permission android:name="android.permission.INTERNET" />
+    <!-- ACCESS_NETWORK_STATE is required by Qt somehow. Not sure what for. -->
+    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
     <!-- WAKE_LOCK is used to prevent the device from severing the connection to
          the server by sleeping when it is locked -->
     <uses-permission android:name="android.permission.WAKE_LOCK" />
+    <!-- WRITE_EXTERNAL_STORAGE only does something on older Android. -->
+    <uses-permission
+        android:name="android.permission.WRITE_EXTERNAL_STORAGE"
+        android:maxSdkVersion="29"
+        tools:ignore="ScopedStorage" />
     <!-- %%INSERT_FEATURES -->
     <supports-screens
         android:anyDensity="true"