Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc add retry middleware #1561

Merged
merged 2 commits into from
Aug 12, 2022
Merged

feat: grpc add retry middleware #1561

merged 2 commits into from
Aug 12, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • GRPC client add retry middleware.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.6 milestone Aug 12, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner August 12, 2022 09:37
@gaius-qi gaius-qi self-assigned this Aug 12, 2022
bigerous
bigerous previously approved these changes Aug 12, 2022
Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim3ma
jim3ma previously approved these changes Aug 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1561 (cf3b282) into main (d20867c) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   44.71%   44.92%   +0.21%     
==========================================
  Files         116      116              
  Lines       10521    10521              
==========================================
+ Hits         4704     4727      +23     
+ Misses       5337     5309      -28     
- Partials      480      485       +5     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 44.92% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ent/daemon/peer/peertask_piecetask_synchronizer.go 47.61% <0.00%> (-1.30%) ⬇️
client/daemon/peer/piece_manager.go 53.45% <0.00%> (+0.53%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 47.10% <0.00%> (+16.66%) ⬆️

@gaius-qi gaius-qi dismissed stale reviews from jim3ma and bigerous via 64e419c August 12, 2022 10:05
@gaius-qi gaius-qi merged commit 7086f97 into main Aug 12, 2022
@gaius-qi gaius-qi deleted the feature/grpc-retry branch August 12, 2022 10:11
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants