Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.2 fails to format #42

Closed
mikehdt opened this issue Aug 11, 2022 · 4 comments
Closed

0.13.2 fails to format #42

mikehdt opened this issue Aug 11, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@mikehdt
Copy link

mikehdt commented Aug 11, 2022

A few hours ago I noticed VSC/dprint had stopped formatting files, and if the VSC window was unfocused, it'd just show an infinite progress bar for dprint in the lower corner. I hadn't noticed that VSC had installed an extension update, until I went and investigated a little.

I've rolled the dprint plugin back to 0.13.1 for now and it works again. Might need to check the code committed for 0.13.2? Happy to help debug if I can. This is on a Mac running MacOS 12.5.

@Nathusan
Copy link

Nathusan commented Aug 11, 2022

I've got the same issue! Reverting back has fixed the issue

@dsherret
Copy link
Member

Hey, what version of dprint are you using? I tried to reproduce this on mac this morning, but couldn't, then tried formatting on an old version of dprint that uses the old editor service and yeah it doesn't format anymore. If you upgrade to a new version it should be fixed, but that said I'm going to look into fixing it now for the old one.

@dsherret dsherret added the bug Something isn't working label Aug 11, 2022
@dsherret
Copy link
Member

dsherret commented Aug 11, 2022

Ok, just published 0.13.3 which fixes this. Should be available within 30 minutes.

Sorry about that! The dprint vscode plugin is the only part of dprint that doesn't have a lot of tests and I've been slowly working on adding some. I'll have to add the old version of dprint to the test suite.

@mikehdt
Copy link
Author

mikehdt commented Aug 11, 2022

Thanks, will give it a whirl. (edit: working great so far! Thanks 😄)

I've got dprint 0.30.3 installed generally, but I suspect that the code I work with has its own version embedded within the project (I think I've seen 0.19.1 floating around) so... yeah. It's an interesting one 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants