Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Verification for Headless #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daneski13
Copy link

I ran into some issues where it wasn't logging into my account since Yahoo asked for a verification code from my recovery email or phone number rather than a CAPTCHA.

With this addition, yahooquery will prompt the user for the verification code sent to the phone/email and input it accordingly to complete sign-in.

I also set the page loading strategy to eager since we only don't need to wait for any CSS or JS downloading in the background, it speeds up the process a bit.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.89%. Comparing base (399284b) to head (4333121).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
yahooquery/headless.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   93.81%   92.89%   -0.93%     
==========================================
  Files          15       15              
  Lines        1359     1380      +21     
==========================================
+ Hits         1275     1282       +7     
- Misses         84       98      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant