Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordions don't always display closed animation. #934

Open
alan-cole opened this issue Apr 7, 2021 · 1 comment
Open

Accordions don't always display closed animation. #934

alan-cole opened this issue Apr 7, 2021 · 1 comment
Labels
bug report contributions-welcome Pull Requests welcome for this issue! on-roadmap Has been added to internal SDP roadmap

Comments

@alan-cole
Copy link
Collaborator

alan-cole commented Apr 7, 2021

Describe the bug
Accordions display a slide down animation on open. (Correct)
On close, the animation often does not display and will usually close immediately. (Incorrect)
When clicking an accordion header during it's transition; it will either immediately open or close, with a slight delay before the text hides. This can lead to an open accordion with no text. (Generally it looks buggy)

To Reproduce
Steps to reproduce the behaviour:

  1. Go to https://www.ripple.sdp.vic.gov.au/?path=/story/organisms-accordion--accordion
  2. Repeatedly click the accordion to open and shut and observe results. See video below as an example.

Expected behaviour
Clicking an accordion to open will display a slide down animation. Clicking to close will display a slide up animation. Clicking during a transition should halt the current animation and perform the expected (opposite) animation. E.g. Click while opening should initiate close / clicking while closing should initiate open.

Actual behaviour
See "Describe the bug"

Screenshots
https://user-images.githubusercontent.com/12739575/113796671-23b54100-9793-11eb-9cd2-4da281f264c8.mp4

Versions

  • Ripple:

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox / Chrome
@dylankelly
Copy link
Contributor

Hey @alan-cole thanks for the Bug report. I've confirmed the issue, and have added it to the backlog as SDPA-5283. Might need to lock out accordionClick whilst its transitioning, idk i'd have to have a look at it in more detail.

@dylankelly dylankelly added contributions-welcome Pull Requests welcome for this issue! on-roadmap Has been added to internal SDP roadmap labels Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report contributions-welcome Pull Requests welcome for this issue! on-roadmap Has been added to internal SDP roadmap
Projects
None yet
Development

No branches or pull requests

2 participants