Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor links with no href should be ignored by markup plugin #1224

Open
dylankelly opened this issue Jul 19, 2022 · 0 comments
Open

Anchor links with no href should be ignored by markup plugin #1224

dylankelly opened this issue Jul 19, 2022 · 0 comments

Comments

@dylankelly
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Anchor links that have no href attribute are being transformed into rpl-text-link when they should be treated as is.

See https://digital-engagement.atlassian.net/browse/SDPSUP-4363

To Reproduce
Steps to reproduce the behaviour:
1.
2.

Expected behaviour
A clear and concise description of what you expected to happen.

Actual behaviour
A clear and concise description of what is actually happening.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • Ripple:

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Add condition in https://github.com/dpc-sdp/ripple/blob/develop/packages/ripple-nuxt-tide/lib/config/markup-plugins.js#L186 to ignore tag transformation if it has no href attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant