Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBaseUrl incorrectly setting the request protocol #1201

Open
dylankelly opened this issue May 25, 2022 · 0 comments
Open

getBaseUrl incorrectly setting the request protocol #1201

dylankelly opened this issue May 25, 2022 · 0 comments

Comments

@dylankelly
Copy link
Contributor

See https://digital-engagement.atlassian.net/browse/SDPSUP-4331

Requests made in HTTPS environments are not correctly setting the baseUrl for requests to the ripple-search-api endpoint when used in a secure HTTPS environment.

See https://github.com/dpc-sdp/ripple/blob/develop/packages/ripple-nuxt-tide/lib/templates/plugin.js#L25

Suggested solution

Check req has secure property set and use that instead.

See https://stackoverflow.com/questions/10348906/how-to-know-if-a-request-is-http-or-https-in-node-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant