Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider turning on caching for Guide object #1283

Open
torymur opened this issue Nov 25, 2024 · 0 comments
Open

Consider turning on caching for Guide object #1283

torymur opened this issue Nov 25, 2024 · 0 comments

Comments

@torymur
Copy link
Contributor

torymur commented Nov 25, 2024

This is a reminder to reconsider turning on caching for the guide, which was turned off due to pickling issues of python bindings provided by outlines-core: #1278

Most likely this will be done after this issue: dottxt-ai/outlines-core#95

torymur pushed a commit to dottxt-ai/outlines-core that referenced this issue Dec 2, 2024
I understand that `pickleable` is not your priority right now. But the
`RegexGuide` needs to be pickled for `vllm` production use, which is
multiprocessing-based.

This PR reintroduces this pickling capability + some tests.

I understand that this introduces more effort on your side.

References:
dottxt-ai/outlines#1274
vllm-project/vllm#10490
vllm-project/vllm#10576
vllm-project/vllm#10489

It would also tackle the current caching issues: 
huggingface/text-generation-inference#2766
dottxt-ai/outlines#1283

Closes:
#95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant