Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy Deletion Code Causes Incorrect Uninstall Logic #2178

Open
nagilson opened this issue Mar 13, 2025 · 0 comments
Open

Legacy Deletion Code Causes Incorrect Uninstall Logic #2178

nagilson opened this issue Mar 13, 2025 · 0 comments

Comments

@nagilson
Copy link
Member

nagilson commented Mar 13, 2025

There is a thing called the 'graveyard' which was meant to handle legacy install type objects and storage state from old extension versions that are now very old. This logic now basically does nothing as most of that has been deprecated and there are very few people on those versions. In fact, there is a weird bug where it will create an infinite set of uninstalls under certain concurrency and invalid memory state conditions with different extension versions. This should be fixed. The logic for tracking and holding a lock is also mildly faulty during uninstall since the installing state and promises are not true to what they actually do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant