From 279e83719e766b8e3357b5038fe04d8793eb7e57 Mon Sep 17 00:00:00 2001 From: YuliiaKovalova Date: Wed, 15 Jan 2025 13:11:01 +0100 Subject: [PATCH 1/4] enable buildcheck --- eng/common/build.ps1 | 1 + eng/common/build.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/eng/common/build.ps1 b/eng/common/build.ps1 index 438f9920c43..5c0baf38fba 100644 --- a/eng/common/build.ps1 +++ b/eng/common/build.ps1 @@ -113,6 +113,7 @@ function Build { MSBuild $toolsetBuildProj ` $bl ` $platformArg ` + /check ` /p:Configuration=$configuration ` /p:RepoRoot=$RepoRoot ` /p:Restore=$restore ` diff --git a/eng/common/build.sh b/eng/common/build.sh index 483647daf18..b22472ec590 100755 --- a/eng/common/build.sh +++ b/eng/common/build.sh @@ -226,6 +226,7 @@ function Build { MSBuild $_InitializeToolset \ $bl \ + /check \ /p:Configuration=$configuration \ /p:RepoRoot="$repo_root" \ /p:Restore=$restore \ From e3e378787a12ff45f1c8832e806b474f22dcba57 Mon Sep 17 00:00:00 2001 From: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Date: Wed, 15 Jan 2025 13:54:00 +0100 Subject: [PATCH 2/4] add buildCheck settings to .editorconfig --- .editorconfig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index 2d1de09be0c..ca3766ad3fe 100644 --- a/.editorconfig +++ b/.editorconfig @@ -674,5 +674,9 @@ dotnet_analyzer_diagnostic.severity = none [*.txt] insert_final_newline = false +# Build Checks +[*.csproj] +build_check.BC0201.AllowUninitializedPropertiesInConditions=true +build_check.BC0202.AllowUninitializedPropertiesInConditions=true [test/**/{Approvals,Snapshots}/**] -trim_trailing_whitespace = false \ No newline at end of file +trim_trailing_whitespace = false From 213577531ac6994295cbc3cab7bad93f7f73868d Mon Sep 17 00:00:00 2001 From: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Date: Wed, 15 Jan 2025 15:46:10 +0100 Subject: [PATCH 3/4] Reorder and add new .editorconfig section --- .editorconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.editorconfig b/.editorconfig index ca3766ad3fe..075706dee79 100644 --- a/.editorconfig +++ b/.editorconfig @@ -674,9 +674,10 @@ dotnet_analyzer_diagnostic.severity = none [*.txt] insert_final_newline = false +[test/**/{Approvals,Snapshots}/**] +trim_trailing_whitespace = false + # Build Checks [*.csproj] build_check.BC0201.AllowUninitializedPropertiesInConditions=true build_check.BC0202.AllowUninitializedPropertiesInConditions=true -[test/**/{Approvals,Snapshots}/**] -trim_trailing_whitespace = false From 9dea73e52b029967d9e0405ea4cc2fbebad60fe2 Mon Sep 17 00:00:00 2001 From: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Date: Tue, 18 Mar 2025 17:24:32 +0100 Subject: [PATCH 4/4] Add BuildChecks to .editorconfig --- .editorconfig | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.editorconfig b/.editorconfig index 986773b59ef..5c1192ae3ac 100644 --- a/.editorconfig +++ b/.editorconfig @@ -683,7 +683,16 @@ insert_final_newline = false [test/**/{Approvals,Snapshots}/**] trim_trailing_whitespace = false -# Build Checks -[*.csproj] -build_check.BC0201.AllowUninitializedPropertiesInConditions=true -build_check.BC0202.AllowUninitializedPropertiesInConditions=true + # Build Checks +[*.{csproj,vbproj,proj,nativeproj,locproj}] +build_check.BC0101.Severity=suggestion +build_check.BC0102.Severity=suggestion +build_check.BC0103.Severity=suggestion +build_check.BC0104.Severity=suggestion +build_check.BC0105.Severity=suggestion +build_check.BC0106.Severity=suggestion +build_check.BC0107.Severity=suggestion +build_check.BC0201.Severity=suggestion +build_check.BC0202.Severity=suggestion +build_check.BC0203.Severity=suggestion +