Skip to content

Commit a0631dd

Browse files
CopilotViktorHofer
andauthored
React to PermissionRequestResultKind breaking change in GitHub.Copilot.SDK 0.1.32 (#326)
* Initial plan * Fix PermissionRequestResultKind breaking change in SDK 0.1.32 Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>
1 parent dec3f06 commit a0631dd

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

eng/skill-validator/src/Services/AgentRunner.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ internal static SessionConfig BuildSessionConfig(
148148
var result = CheckPermission(request, workDir, skillPath);
149149
return Task.FromResult(new PermissionRequestResult
150150
{
151-
Kind = result ? "approved" : "denied-by-rules",
151+
Kind = result ? PermissionRequestResultKind.Approved : PermissionRequestResultKind.DeniedByRules,
152152
});
153153
},
154154
};

eng/skill-validator/src/Services/Judge.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private static async Task<JudgeResult> JudgeRunOnce(
5050
var result = AgentRunner.CheckPermission(request, options.WorkDir, options.SkillPath);
5151
return Task.FromResult(new PermissionRequestResult
5252
{
53-
Kind = result ? "approved" : "denied-by-rules",
53+
Kind = result ? PermissionRequestResultKind.Approved : PermissionRequestResultKind.DeniedByRules,
5454
});
5555
},
5656
});

eng/skill-validator/src/Services/OverfittingJudge.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ private static async Task<OverfittingResult> AnalyzeOnce(SkillInfo skill, Overfi
5959
// No tools needed — all content is passed inline
6060
OnPermissionRequest = (_, _) => Task.FromResult(new PermissionRequestResult
6161
{
62-
Kind = "denied-by-rules",
62+
Kind = PermissionRequestResultKind.DeniedByRules,
6363
}),
6464
});
6565

@@ -120,7 +120,7 @@ public static async Task GenerateFix(SkillInfo skill, OverfittingResult result,
120120
InfiniteSessions = new InfiniteSessionConfig { Enabled = false },
121121
OnPermissionRequest = (_, _) => Task.FromResult(new PermissionRequestResult
122122
{
123-
Kind = "denied-by-rules",
123+
Kind = PermissionRequestResultKind.DeniedByRules,
124124
}),
125125
});
126126

eng/skill-validator/src/Services/PairwiseJudge.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ private static async Task<PairwiseJudgeResult> JudgeCall(
8585
var result = AgentRunner.CheckPermission(request, options.WorkDir, options.SkillPath);
8686
return Task.FromResult(new PermissionRequestResult
8787
{
88-
Kind = result ? "approved" : "denied-by-rules",
88+
Kind = result ? PermissionRequestResultKind.Approved : PermissionRequestResultKind.DeniedByRules,
8989
});
9090
},
9191
});

0 commit comments

Comments
 (0)