Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest changes from NuGet that allow for modal dialogs to be launched #46423

Open
baronfel opened this issue Jan 30, 2025 · 0 comments
Open

Ingest changes from NuGet that allow for modal dialogs to be launched #46423

baronfel opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
Area-Infrastructure untriaged Request triage from a team member

Comments

@baronfel
Copy link
Member

baronfel commented Jan 30, 2025

This is the tracking issue for NuGet/Home#14010 because GitHub subissues can't be linked across repositories or organizations.

SDK is on-board with NuGet changing canShowDialog, and so this tracks merging the fix from their end once it is made.

Major changes in user experience are:

current state

Tokens can be long-lived based on org configurations. 7 or 30 days is not uncommon. These long-lived tokens are exchanged for short-lived tokens transparently. The authentication flow is the device code flow.

When a user interactively authenticates today, a message is printed to the console directing a user to navigate to a specific url, where they can authenticate, which unblocks the build.

proposed new state

Long-lived tokens will have a day lifespan. These tokens are exchanged for short-lived tokens transparently.

When a user interactively authenticates today, a browser will open automatically that the user can authenticate through. A message is printed to the build alerting the user to this. Once the authentication flow is completed the build is unblocked.

Key validation points

After this change, builds through msbuild.exe, dotnet msbuild and dotnet build should still

  • fail authentication if unauthenticated and --interactive is not passed
  • trigger the authentication flow with a console message + browser popup if --interactive is allowed.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants