[dotnet-run] Implement DeployToDevice target invocation (#52046)

Context: https://github.com/dotnet/sdk/blob/49c0d73c0bfa9eb2870827828354d5c96ed786f0/documentation/specs/dotnet-run-for-maui.md
Context: dotnet/android#10631
Context: dotnet/android#10640

Add support for calling the `DeployToDevice` MSBuild target during
`dotnet run`. The target is invoked after the build step (or with
--no-build) to enable deployment to physical devices or emulators.

The main change here is to create the `RunCommandSelector` earlier in
the `RunCommand` execution, so that it can be used both for selecting
the target framework and device before build, and for invoking the
`DeployToDevice` target after build.

I tested this by making `DotnetRunDevices.csproj` include a target:

    <Target Name="DeployToDevice" DependsOnTargets="ResolveFrameworkReferences">
      <Message Text="DeployToDevice: Deployed to device $(Device) with RuntimeIdentifier $(RuntimeIdentifier)" Importance="high" />
    </Target>

Where `DependsOnTargets="ResolveFrameworkReferences"` mimics what can
happen in the Android workload.

I had to stop caching each `ProjectInstance` in `RunCommandSelector`,
as doing so can cause:

    》"artifacts\tmp\Debug\testing\ItDoesNotCall---A078BA19\DotnetRunDevices.csproj" (DeployToDevice target) (1) ->
    》(ResolveFrameworkReferences target) ->
    》  artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018: The "ResolveFrameworkReferences" task failed unexpectedly.
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018: System.ArgumentException: An item with the same key has already been added. Key: Microsoft.NETCore.App
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at System.Linq.Enumerable.SpanToDictionary[TSource,TKey](ReadOnlySpan`1 source, Func`2 keySelector, IEqualityComparer`1 comparer)
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at System.Linq.Enumerable.ToDictionary[TSource,TKey](IEnumerable`1 source, Func`2 keySelector, IEqualityComparer`1 comparer)
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ResolveFrameworkReferences.ExecuteCore() in src\Tasks\Microsoft.NET.Build.Tasks\ResolveFrameworkReferences.cs:line 29
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() in src\Tasks\Common\TaskBase.cs:line 36
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Execute()
    》artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(410,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

The `ResolveFrameworkReferences` target will add duplicate
`Microsoft.NETCore.App` items within a `ProjectInstance` causing the
exception above.

Author: jonathanpeppers

src/Cli/Microsoft.DotNet.Cli.Utils/Constants.cs

@@ -30,6 +30,7 @@ public static class Constants
     public const string Build = nameof(Build);
     public const string ComputeRunArguments = nameof(ComputeRunArguments);
     public const string ComputeAvailableDevices = nameof(ComputeAvailableDevices);
+    public const string DeployToDevice = nameof(DeployToDevice);
     public const string CoreCompile = nameof(CoreCompile);
 
     // MSBuild item metadata

src/Cli/dotnet/Commands/CliCommandStrings.resx

@@ -1693,6 +1693,9 @@ The default is to publish a framework-dependent application.</value>
   <data name="RunCommandException" xml:space="preserve">
     <value>The build failed. Fix the build errors and run again.</value>
   </data>
+  <data name="RunCommandDeployFailed" xml:space="preserve">
+    <value>Deployment to device failed. Fix any deployment errors and run again.</value>
+  </data>
   <data name="RunCommandExceptionCouldNotApplyLaunchSettings" xml:space="preserve">
     <value>The launch profile "{0}" could not be applied.
 {1}</value>

src/Cli/dotnet/Commands/Run/RunCommand.cs

@@ -159,7 +159,10 @@ public int Execute()
         try
         {
             // Pre-run evaluation: Handle target framework and device selection for project-based scenarios
-            if (ProjectFileFullPath is not null && !TrySelectTargetFrameworkAndDeviceIfNeeded(logger))
+            using var selector = ProjectFileFullPath is not null
+                ? new RunCommandSelector(ProjectFileFullPath, Interactive, MSBuildArgs, logger)
+                : null;
+            if (selector is not null && !TrySelectTargetFrameworkAndDeviceIfNeeded(selector))
             {
                 // If --list-devices was specified, this is a successful exit
                 return ListDevices ? 0 : 1;
@@ -202,6 +205,17 @@ public int Execute()
                 cachedRunProperties = cacheEntry?.Run;
             }
 
+            // Deploy step: Call DeployToDevice target if available
+            // This must run even with --no-build, as the user may have selected a different device
+            if (selector is not null && !selector.TryDeployToDevice())
+            {
+                // Only error if we have a valid project (not a .sln file, etc.)
+                if (selector.HasValidProject)
+                {
+                    throw new GracefulException(CliCommandStrings.RunCommandDeployFailed);
+                }
+            }
+
             var targetCommand = GetTargetCommand(launchProfileParseResult.Profile, projectFactory, cachedRunProperties, logger);
 
             // Send telemetry about the run operation
@@ -238,12 +252,10 @@ internal ICommand GetTargetCommand(LaunchProfile? launchSettings, Func<ProjectCo
     /// Uses a single RunCommandSelector instance for both operations, re-evaluating
     /// the project after framework selection to get the correct device list.
     /// </summary>
-    /// <param name="logger">Optional logger for MSBuild operations (device selection)</param>
+    /// <param name="selector">The RunCommandSelector instance to use for selection</param>
     /// <returns>True if we can continue, false if we should exit</returns>
-    private bool TrySelectTargetFrameworkAndDeviceIfNeeded(FacadeLogger? logger)
+    private bool TrySelectTargetFrameworkAndDeviceIfNeeded(RunCommandSelector selector)
     {
-        Debug.Assert(ProjectFileFullPath is not null);
-
         var globalProperties = CommonRunHelpers.GetGlobalPropertiesFromArgs(MSBuildArgs);
 
         // If user specified --device on command line, add it to global properties and MSBuildArgs
@@ -262,13 +274,10 @@ private bool TrySelectTargetFrameworkAndDeviceIfNeeded(FacadeLogger? logger)
 
         if (!ListDevices && hasFramework && hasDevice)
         {
-            // Both framework and device are pre-specified, no need to create selector or logger
+            // Both framework and device are pre-specified
             return true;
         }
 
-        // Create a single selector for both framework and device selection
-        using var selector = new RunCommandSelector(ProjectFileFullPath, globalProperties, Interactive, MSBuildArgs, logger);
-        
         // Step 1: Select target framework if needed
         if (!selector.TrySelectTargetFramework(out string? selectedFramework))
         {

src/Cli/dotnet/Commands/Run/RunCommandSelector.cs

@@ -31,21 +31,25 @@ internal sealed class RunCommandSelector : IDisposable
 
     private ProjectCollection? _collection;
     private Microsoft.Build.Evaluation.Project? _project;
-    private ProjectInstance? _projectInstance;
+
+    /// <summary>
+    /// Gets whether the selector has a valid project that can be evaluated.
+    /// This is false for .sln files or other invalid project files.
+    /// </summary>
+    public bool HasValidProject { get; private set; }
 
     /// <param name="projectFilePath">Path to the project file to evaluate</param>
-    /// <param name="globalProperties">Global MSBuild properties to use during evaluation</param>
     /// <param name="isInteractive">Whether to prompt the user for selections</param>
+    /// <param name="msbuildArgs">MSBuild arguments containing properties and verbosity settings</param>
     /// <param name="binaryLogger">Optional binary logger for MSBuild operations. The logger will not be disposed by this class.</param>
     public RunCommandSelector(
         string projectFilePath,
-        Dictionary<string, string> globalProperties,
         bool isInteractive,
         MSBuildArgs msbuildArgs,
         FacadeLogger? binaryLogger = null)
     {
         _projectFilePath = projectFilePath;
-        _globalProperties = globalProperties;
+        _globalProperties = CommonRunHelpers.GetGlobalPropertiesFromArgs(msbuildArgs);
         _isInteractive = isInteractive;
         _msbuildArgs = msbuildArgs;
         _binaryLogger = binaryLogger;
@@ -102,9 +106,9 @@ public void InvalidateGlobalProperties(Dictionary<string, string> updatedPropert
 
         // Dispose existing project to force re-evaluation
         _project = null;
-        _projectInstance = null;
         _collection?.Dispose();
         _collection = null;
+        HasValidProject = false;
     }
 
     /// <summary>
@@ -114,8 +118,10 @@ private bool OpenProjectIfNeeded([NotNullWhen(true)] out ProjectInstance? projec
     {
         if (_project is not null)
         {
-            Debug.Assert(_projectInstance is not null);
-            projectInstance = _projectInstance;
+            // Create a fresh ProjectInstance for each build operation
+            // to avoid accumulating state (existing item groups) from previous builds
+            projectInstance = _project.CreateProjectInstance();
+            HasValidProject = true;
             return true;
         }
 
@@ -126,14 +132,15 @@ private bool OpenProjectIfNeeded([NotNullWhen(true)] out ProjectInstance? projec
                 loggers: GetLoggers(),
                 toolsetDefinitionLocations: ToolsetDefinitionLocations.Default);
             _project = _collection.LoadProject(_projectFilePath);
-            _projectInstance = _project.CreateProjectInstance();
-            projectInstance = _projectInstance;
+            projectInstance = _project.CreateProjectInstance();
+            HasValidProject = true;
             return true;
         }
         catch (InvalidProjectFileException)
         {
             // Invalid project file, return false
             projectInstance = null;
+            HasValidProject = false;
             return false;
         }
     }
@@ -461,6 +468,36 @@ public bool TrySelectDevice(
         }
     }
 
+    /// <summary>
+    /// Attempts to deploy to a device by calling the DeployToDevice MSBuild target if it exists.
+    /// This reuses the already-loaded project instance for performance.
+    /// </summary>
+    /// <returns>True if deployment succeeded or was skipped (no target), false if deployment failed</returns>
+    public bool TryDeployToDevice()
+    {
+        if (!OpenProjectIfNeeded(out var projectInstance))
+        {
+            // Invalid project file
+            return false;
+        }
+
+        // Check if the DeployToDevice target exists in the project
+        if (!projectInstance.Targets.ContainsKey(Constants.DeployToDevice))
+        {
+            // Target doesn't exist, skip deploy step
+            return true;
+        }
+
+        // Build the DeployToDevice target
+        var buildResult = projectInstance.Build(
+            targets: [Constants.DeployToDevice],
+            loggers: GetLoggers(),
+            remoteLoggers: null,
+            out _);
+
+        return buildResult;
+    }
+
     /// <summary>
     /// Gets the list of loggers to use for MSBuild operations.
     /// Creates a fresh console logger each time to avoid disposal issues when calling Build() multiple times.