Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag stale PR validation builds #97653

Open
ericstj opened this issue Jan 29, 2024 · 5 comments
Open

Flag stale PR validation builds #97653

ericstj opened this issue Jan 29, 2024 · 5 comments

Comments

@ericstj
Copy link
Member

ericstj commented Jan 29, 2024

Merging PRs with stale results can introduce build breaks or test failures because the code might have been validated on an old codebase.

We should make it obvious when we have build results that are older than a couple weeks - or maybe older by a number of commits. That way we avoid folks accidentally merging with stale results.

I know AzDo has a policy setting for this - maybe github does as well?

@ghost
Copy link

ghost commented Jan 29, 2024

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Merging PRs with stale results can introduce build breaks or test failures because the code might have been validated on an old codebase.

We should make it obvious when we have build results that are older than a couple weeks - or maybe older by a number of commits. That way we avoid folks accidentally merging with stale results.

I know AzDo has a policy setting for this - maybe github does as well?

Author: ericstj
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 29, 2024
@ViktorHofer
Copy link
Member

image

GH offers the branch must be "up-to-date" setting but that doesn't work well in high traffic repositories. You would constantly need to sync to latest and wait for CI to finish. By that time, your HEAD likely isn't in sync with runtime's HEAD anymore.

In addition to that, this feature is coupled with the "require status check to pass before merge" feature which we don't have enabled in runtime.

@vcsjones
Copy link
Member

This could be solved with a GitHub action. Have the action run on commits to main (A PR was merged) and have the action enumerate all open pull requests and their reviews, and dismiss the review if its older than whatever you configure it to be.

If this sounds interesting I can help develop the action.

@jkoritzinsky
Copy link
Member

It might be worthwhile looking into the GitHub Merge Queue feature to support us here once we finish the Merge-on-Green initiative.

@akoeplinger
Copy link
Member

akoeplinger commented Jan 30, 2024

Instead of a policy a quick reminder comment by @msftbot would probably help too and I think we have all the infrastructure in place for this since we already post the "no recent activity" comment and close PRs after a while.

@agocke agocke added this to the Future milestone Jul 8, 2024
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants