-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag stale PR validation builds #97653
Comments
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsMerging PRs with stale results can introduce build breaks or test failures because the code might have been validated on an old codebase. We should make it obvious when we have build results that are older than a couple weeks - or maybe older by a number of commits. That way we avoid folks accidentally merging with stale results. I know AzDo has a policy setting for this - maybe github does as well?
|
GH offers the branch must be "up-to-date" setting but that doesn't work well in high traffic repositories. You would constantly need to sync to latest and wait for CI to finish. By that time, your HEAD likely isn't in sync with runtime's HEAD anymore. In addition to that, this feature is coupled with the "require status check to pass before merge" feature which we don't have enabled in runtime. |
This could be solved with a GitHub action. Have the action run on commits to If this sounds interesting I can help develop the action. |
It might be worthwhile looking into the GitHub Merge Queue feature to support us here once we finish the Merge-on-Green initiative. |
Instead of a policy a quick reminder comment by @msftbot would probably help too and I think we have all the infrastructure in place for this since we already post the "no recent activity" comment and close PRs after a while. |
Merging PRs with stale results can introduce build breaks or test failures because the code might have been validated on an old codebase.
We should make it obvious when we have build results that are older than a couple weeks - or maybe older by a number of commits. That way we avoid folks accidentally merging with stale results.
I know AzDo has a policy setting for this - maybe github does as well?
The text was updated successfully, but these errors were encountered: