FormattedLogValues struct should be public

[zuntio]

https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Logging.Abstractions/src/FormattedLogValues.cs should be imho public.

There are use cases where I want to log and return or throw same string. Would be handy to do something like:

var template = "Encountered data {Data}!";
_logger.LogInformation(template, data);
return new FormattedLogValues(template, data).ToString();

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

---

https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Logging.Abstractions/src/FormattedLogValues.cs should be imho public.

There are use cases where I want to log and return or throw same string. Would be handy to do something like:

var template = "Encountered data {Data}!";
_logger.LogInformation(template, data);
return new FormattedLogValues(template, data).ToString();

Author:	zuntio
Assignees:	-
Labels:	untriaged, area-Extensions-Logging
Milestone:	-

[maryamariyan]

Why do you need FormattedLogValues?

Would you please share more about the scenario in which you are have that would need the logged string to be returned?

This issue has been marked needs-author-action since it may be missing important information. Please refer to our contribution guidelines for tips on how to report issues effectively.

[maryamariyan]

Related closed PR dotnet/extensions#2814 (comment)

This has been made internal before: dotnet/extensions#513

[zuntio]

For example in customer facing APIs it is usually handy to return human readable error. When customer contacts about problem encountered, the first thing they send is the error message but not any traceable guids. It makes triaging customer issues much faster.

[maryamariyan]

@davidfowl @pakrym was there a strong reason to keep this internal in the PR dotnet/extensions#513

[davidfowl]

There wasn't a strong reason to keep it public so we made it internal. There hasn't been many great explanations as to how it's being used.

[SirSavio]

Here we see an example where make public make a difference
nsubstitute/NSubstitute#384