Skip to content

Remove ReadLock struct from System.Composition #15097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsplaisted opened this issue Aug 27, 2015 · 0 comments
Closed

Remove ReadLock struct from System.Composition #15097

dsplaisted opened this issue Aug 27, 2015 · 0 comments
Assignees
Labels
area-System.Composition help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@dsplaisted
Copy link
Member

Per previous discussion this type is currently being used safely, but would be easy to accidentally use incorrectly. We can remove it and replace its usage with something like the following:

_lock.EnterReadLock();
try { 
    _memberInfos.TryGetValue(memberInfo, out cachedAttributes);
}
finally { _lock.ExitReadLock(); }
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Composition help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

2 participants