Conversation
Capture opt-in loopback phases and client task outcomes without changing request reuse, shutdown, assertions, or timeout budgets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The instrumentation is opt-in, thread-safe, and preserves existing request and connection behavior.
Review effort: Lite
Findings: None
What changed in this PR
Adds opt-in diagnostics for HTTP/3 request-reuse timeout investigation without changing test behavior.
Changes:
- Buffers timestamped client/server diagnostics safely.
- Logs HTTP/3 connection, stream, response, disconnect, and disposal phases.
- Captures client task status and exceptions on failure.
| File | Description |
|---|---|
DiagnosticsTests.cs |
Adds request and client-task diagnostics. |
Http3LoopbackServer.cs |
Adds optional logging and exception diagnostics. |
Http3LoopbackConnection.cs |
Logs HTTP/3 lifecycle operations. |
Member
Author
|
/azp run runtime Note CI rerun requested by GitHub Copilot at the author's request to investigate the intermittent HTTP/3 timeout without merging this PR. |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run runtime |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Sep 23, 2026
Member
Author
|
/azp run runtime |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Sep 23, 2026
Member
Author
|
/azp run runtime |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add instrumentation to investigate the factory timeout in
SocketsHttpHandler_DiagnosticsTest_Http3.SendAsync_ReuseRequestInHandler_ResetsHeadersForEachReuse, tracked by #132085.The test observes its client task only after three server transactions complete. A factory timeout currently does not tell us whether that task faulted or which loopback operation is pending. This change records:
Messages are timestamped and buffered in a thread-safe queue, then written to xUnit output outside the factory callback. A callback that outlives the factory timeout therefore does not write to a finished test's output helper. Other loopback users leave logging disabled.
This is instrumentation only, not a claimed fix or root-cause diagnosis. It preserves the existing header assertions, request instance reuse, statuses, connection sequencing, GOAWAY/shutdown behavior, and timeout budgets. It does not add retries, cancellation changes, or quarantines.
Validation
Windows x64, locally built .NET 11, libraries Debug / CoreCLR Release:
build.cmd clr+libs -rc release: passed, zero warnings/errors.System.Net.Http.Functional.Testsinner-loop suite: 5,476 total; 5,428 passed, 48 skipped, zero failures.TimeoutException, while its output exposedClient task status: Faulted, the underlyingHttpRequestExceptionand stack, and the pending connection-accept phase. No fault injection is included in the patch.The original Alpine 3.24/Linux-musl failure was not reproduced locally. These Windows results validate the added instrumentation, not a fix for that failure.
Related to #132085; intentionally left open for the underlying investigation.
Note
This PR was prepared with GitHub Copilot.