System.TypeLoadException from static field

[hamarb123]

Description

The runtime seems to throw a System.TypeLoadException on a struct S1 with a static field of type Nullable<S1>.

Reproduction Steps

Run the following code:

S1.X();

struct S1
{
    private static S1? _s1;
    public static void X() { }
}

https://sharplab.io/#v2:C4LgTgrgdgNAJiA1AHwMoEYB0ANAFASgG4BYAKDIGdhIBjYAAgzIG8z736AHMASwDcAhsACm9AALoAbI3QB+egH0K6EqQ7iAzOKniALPTz56zegF8y50kA==

Expected behavior

Does not crash

Actual behavior

Crashes:

System.TypeLoadException: Could not load type 'S1' from assembly '_, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'.
   at Program.<Main>$(String[] args)
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

Regression?

No response

Known Workarounds

No response

Configuration

Windows 10.0.19045.4291 x64
.NET 8.0.4
And Sharplab.io

Other information

No response

[Tornhoof]

See #79636

[hamarb123]

Found this following that trail: #6924 (comment) - I see no other issue for it

[hamarb123]

Duplicate of #88030

[hamarb123]

Actually, that issue, while very similar, is not exactly the same as this one - in the other one the generic parameter is not actually used, whereas for Nullable<T> it would be. I'll reopen so someone on runtime team can decide if they should be merged or separate (since, to my way of thinking at least, depending on how the other one gets fixed, it might not actually fix my one).

[steveisok]

/cc @fanyang-mono

[steveisok]

Closing as it's a duplicate of #104511

[kg]

This looks like it's actually different from 104511 somehow. Not sure what's going on yet.

EDIT: This one fails an assertion starting at

runtime/src/coreclr/vm/methodtablebuilder.cpp

Line 10065 in 2c77535

if (g_pNullableClass != NULL)

because the two sizes don't match at

runtime/src/coreclr/vm/methodtablebuilder.cpp

Line 10088 in 2c77535

_ASSERTE(pMT->GetNullableNumInstanceFieldBytes() == pMT->GetNumInstanceFieldBytes());

and then it throws a special type loading exception despite the use of tkTypeDefToAvoidIfPossible to avoid S1.
The type load failure initially appears to be because the layout comparison here failed and iRecursiveGenericFieldHandlingPass == 1:

runtime/src/coreclr/vm/siginfo.cpp

Line 1608 in 2c77535

bool failedLayoutCompare = objectSizeCanonInstantiation != objectSizeByteInstantion;