Commit 696cea0
Preserve default Ninja behavior when MSBuild property is unset (#134471)
## Summary
Unset `Ninja` properties were treated as explicitly disabled, overriding
the native build scripts’ default generator selection. Elsewhere in the
clr build, Ninja is treated as the default. Usually this is propagated
from the outer ./build.sh, but when building one of these projects
directly (as trimmer tests do) without explicitly setting
`/p:Ninja=true`, it defaults to Makefiles. This causes the build to fail
if CMakeCache.txt is present after previous build used the default
`Ninja`.
## Changes
- Pass `-ninja false` only when `Ninja=false`.
- Preserve explicit `Ninja=true` behavior.
- Retain the existing Windows-specific MSBuild selection.
- Apply consistently across CoreCLR, corehost, and native libraries.
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>1 parent bcd5bcb commit 696cea0
3 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
0 commit comments