Skip to content

Commit 513b9cd

Browse files
radekdoulikCopilot
andauthored
Fix scheduled WASM extra-platforms job selection (#134613)
## Problem The scheduled `runtime-extra-platforms` pipeline includes this child template only for rolling builds, but since #133068 the child has repeated that check through `variables.isRollingBuild`. That ambient variable is unavailable during nested compile-time expansion, so it expands empty and the child selects the WASM-specific branches instead. Build 1610154 consequently omitted `LibraryTestsCoreCLR_R2R` and `TestWasmReadyToRun` while adding `SingleThreaded_BuildOnly` and non-extra browser CoreCLR jobs. ## Fix Use the explicit `isExtraPlatformsBuild` parameter to select the scheduled extra-platforms branch and its inverse for WASM-specific pipeline invocations. Use the explicit `isWasmOnlyBuild` parameter for WASI smoke `alwaysRun` behavior. ## Validation - parsed `eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml` successfully as YAML - authenticated Azure DevOps definition 154 preview against the PR merge ref includes `LibraryTestsCoreCLR_R2R` and `TestWasmReadyToRun` - preview includes both browser smoke AOT jobs, both WASI AOT jobs, and both browser high-resource AOT jobs - preview contains no `SingleThreaded_BuildOnly` references and no non-extra browser CoreCLR build-only jobs - no pipeline run was queued; validation used the preview API only `/azp run runtime-extra-platforms` cannot validate this scheduled path on a PR: PR runs set `Build.Reason` to `PullRequest`, which makes the root `isRollingBuild` gate omit the WASM child template entirely. The preview API expands definition 154 against the PR merge ref in the required rolling context without queuing a build. The next daily scheduled run after merge will provide the end-to-end confirmation. > [!NOTE] > This pull request description was generated with GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 541a2c0a-365a-40d8-adfc-20e687d223b8
1 parent 1613046 commit 513b9cd

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

‎eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ parameters:
1818
jobs:
1919

2020
#
21-
# ************ Rolling builds: *************
21+
# ************ runtime-extra-platforms invocation: *************
2222
# - only run full or expensive library-test configurations
2323
# - rest are covered by runtime
2424
#
25-
- ${{ if eq(variables.isRollingBuild, true) }}:
25+
- ${{ if eq(parameters.isExtraPlatformsBuild, true) }}:
2626
# Full trimmed CoreCLR ReadyToRun library tests
2727
- template: /eng/pipelines/common/templates/wasm-coreclr-library-tests.yml
2828
parameters:
@@ -80,11 +80,11 @@ jobs:
8080
useHelixMonitor: ${{ parameters.useHelixMonitor }}
8181

8282
#
83-
# ********** For !rolling builds, IOW - PR builds *************
83+
# ********** WASM-specific pipeline invocations: *************
8484
# - run everything, if relevant paths changed
8585
# - For runtime-wasm, force run all the jobs
8686
#
87-
- ${{ if and(ne(variables.isRollingBuild, true), ne(parameters.excludeLibTests, true), ne(parameters.debuggerTestsOnly, true)) }}:
87+
- ${{ if and(ne(parameters.isExtraPlatformsBuild, true), ne(parameters.excludeLibTests, true), ne(parameters.debuggerTestsOnly, true)) }}:
8888
# Library tests
8989
# these run on runtime also
9090
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
@@ -205,12 +205,12 @@ jobs:
205205
# ignore test failures for runtime-extra-platforms, but not when this
206206
# is run as part of a wasm specific pipeline like runtime-wasm
207207
shouldContinueOnError: ${{ not(parameters.isWasmOnlyBuild) }}
208-
alwaysRun: ${{ variables.isRollingBuild }}
208+
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
209209
useHelixMonitor: ${{ parameters.useHelixMonitor }}
210210
scenarios:
211211
- WasmTestOnWasmtime
212212

213-
- ${{ if and(ne(variables.isRollingBuild, true), ne(parameters.excludeNonLibTests, true), ne(parameters.debuggerTestsOnly, true)) }}:
213+
- ${{ if and(ne(parameters.isExtraPlatformsBuild, true), ne(parameters.excludeNonLibTests, true), ne(parameters.debuggerTestsOnly, true)) }}:
214214
# Builds only
215215
- template: /eng/pipelines/common/templates/wasm-build-only.yml
216216
parameters:
@@ -289,7 +289,7 @@ jobs:
289289
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
290290
useHelixMonitor: ${{ parameters.useHelixMonitor }}
291291

292-
- ${{ if and(ne(variables.isRollingBuild, true), ne(parameters.excludeOptional, true)) }}:
292+
- ${{ if and(ne(parameters.isExtraPlatformsBuild, true), ne(parameters.excludeOptional, true)) }}:
293293
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
294294
parameters:
295295
platforms:

0 commit comments

Comments
 (0)