Remove option to disable diagnostics #80166
Merged
+88
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
reviewed
Sep 8, 2025
Comment on lines
106
to
107
| // We only support this option to disable crawling in internal speedometer and ddrit perf runs to lower | ||
| // noise. It is not exposed to the user. |
There was a problem hiding this comment.
Comment no longer applies, IIUC.
|
@jasonmalinowski ptal. |
JoeRobich
approved these changes
Sep 8, 2025
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Sep 10, 2025
CyrusNajmabadi
added a commit
that referenced
this pull request
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing how this impacts speedometer.
Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12342588&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/667908