Skip to content

Figure out how to reference files for tests in WASM #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrewScoggins opened this issue Dec 1, 2021 · 3 comments
Open

Figure out how to reference files for tests in WASM #2163

DrewScoggins opened this issue Dec 1, 2021 · 3 comments
Labels
impact test coverage test maybe disabled due to this issue

Comments

@DrewScoggins
Copy link
Member

Currently we use Assembly.Location to build the path for opening files in performance tests, but this does not work on WASM. We should come up with a way to do this.

@DrewScoggins DrewScoggins added the impact test coverage test maybe disabled due to this issue label Dec 1, 2021
@DrewScoggins
Copy link
Member Author

They are disabled for those other tests. I vaguely remember having this discussion before when we were first standing up WASM runs, but I can't find anything about it right now. As for best practices for locating a file, I don't believe we have anything except for what is already checked in. For tests running in the lab we could build the path from scratch using environment variables that we have on running machines, but that would not solve the issue of how we locate the files locally. Maybe @naricc has some insight on the best way to get at the base location in WASM.

From #2162

@naricc
Copy link

naricc commented Dec 2, 2021

There are MSbuild properties that can be set to include arbitrary files in a the wasm virtual file system, I think that would work. BenchmarkDotnet would need to be modified to add those parameters to the generated project though, and then we would need the path to those files when the benchmark project was built (or I could go implement the Source Generator tool chain dotnet/BenchmarkDotNet#1770).

I don't recall exactly what those properties are. @radical @akoeplinger Do you happen to recall?

@radical
Copy link
Member

radical commented Dec 2, 2021

@(WasmFilesToIncludeInFileSystem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact test coverage test maybe disabled due to this issue
Projects
None yet
Development

No branches or pull requests

3 participants