Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp.Core WebExtensions Module uses obsolete classes #18089

Open
alexanderkor opened this issue Nov 29, 2024 · 1 comment
Open

FSharp.Core WebExtensions Module uses obsolete classes #18089

alexanderkor opened this issue Nov 29, 2024 · 1 comment

Comments

@alexanderkor
Copy link

If I get it right, the examples on FSharp.Core WebExtensions Module page use obsolete classes like WebRequest and WebClient and should be using HttpClient instead. https://fsharp.github.io/fsharp-core-docs/reference/fsharp-control-webextensions.html

@Martin521
Copy link
Contributor

Martin521 commented Dec 2, 2024

Unfortunately, this is not just a documentation issue.
I think the FSharp.Control.WebExtensions functions should be deprecated (as they extend a deprecated class).

Should they be replaced by new functions with similar functionality? I doubt it. These functions were beautiful for demoing async, but glossing over all the complexities of error handling. I would rather add a remark recommending the use of one of the existing HttpClient wrappers of the F# ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

3 participants