Nullness :: Bugfix :: Codegen missing metadata for C# consumers (records,DUs,exceptions) #18079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
❗ Release notes required
|
…the fix for attribute codegen for DUs
0101
approved these changes
Nov 29, 2024
...s/EmittedIL/CCtorDUWithMember/CCtorDUWithMember01a.fs.RealInternalSignatureOff.il.net472.bsl
Show resolved
Hide resolved
vzarytovskii
approved these changes
Nov 29, 2024
…-record-members-are-not-visible-from-c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18007
Fixes #18076
Fixes #18077
Fixes #18078
This address holes in metadata generation for C# consumers of nullness information.
Affected areas are:
I spotted a pre-existing nasty bug which caused method attributes overwrite each other, and compilergenerated and debuggersteptrough attributes were until now therefore missing for selected generated methods in subclasses of DUs.
IMPORTANT tip for reviewing:
The attribute codegen fix also meant changing a lot of baselines, even though the only materialchange is addition of the two attributes.
All the baselines which are not about nullness have been updated in a separate commit, so that you can focus on the rest.