Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - constructors for DU cases consumed in C# do not show nullability #18077

Closed
1 of 7 tasks
T-Gro opened this issue Nov 27, 2024 · 0 comments · Fixed by #18079
Closed
1 of 7 tasks

Nullness issue - constructors for DU cases consumed in C# do not show nullability #18077

T-Gro opened this issue Nov 27, 2024 · 0 comments · Fixed by #18079
Assignees
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug
Milestone

Comments

@T-Gro
Copy link
Member

T-Gro commented Nov 27, 2024

Issue description

When consuming a reference DU from C#, the constructors of the generated subclasses do not respect nullability of the fields.

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

No response

Reproducible code snippet and actual behavior

[<NoComparison;NoEquality>]
type MyDu = 
    | JustLabel
    | JustInt of int
    | MaybeString of nullableString:(string | null)

Possible workarounds

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug
Projects
Archived in project
2 participants