Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler codebase chore :: Hash directives around nullness syntax are not needed anymore #18061

Open
T-Gro opened this issue Nov 26, 2024 · 0 comments

Comments

@T-Gro
Copy link
Member

T-Gro commented Nov 26, 2024

While the nullness feature was being developed, the previous compiler (LKG = Last Known Good) did not understand nullness syntax ("not null", | null).
Which lead to null-relevant code surrounded in "#if" directives, to make it compile both under the .NET8 compiler as well as the new .NET9 one.

With .NET being out, those should not be needed anymore.
The same would apply to wrapper types created in order to limit the number of "#if" directives, pretty much most of the NullnessShims.fs file and the broad usage of the "MaybeNull" wrapper.

This can be done incrementally.

@github-actions github-actions bot added this to the Backlog milestone Nov 26, 2024
@T-Gro T-Gro changed the title Compiler codebase chore :: Has directives around nullness syntax are not needed anymore Compiler codebase chore :: Hash directives around nullness syntax are not needed anymore Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

1 participant