Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - Option.ofObj against non-nullable ref type does not trigger FS3262 when using |> #18014

Open
1 of 7 tasks
isaacabraham opened this issue Nov 16, 2024 · 1 comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone

Comments

@isaacabraham
Copy link
Contributor

Issue description

When piping a non-nullable reference type value into Option.ofObj, FS3262 should trigger, but it does not.

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

.NET 9

Reproducible code snippet and actual behavior

let foo = "test"
let bar = foo |> Option.ofObj // does not produce FS3262

Possible workarounds

Do not use |>

let baz = Option.ofObj foo // fires FS3262
@isaacabraham isaacabraham added Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage labels Nov 16, 2024
@github-actions github-actions bot added this to the Backlog milestone Nov 16, 2024
@T-Gro T-Gro removed their assignment Nov 18, 2024
@T-Gro
Copy link
Member

T-Gro commented Nov 18, 2024

FS3262 is not mapped to a "real" language constraint, and it is a bug that it does not flow over the boundary of operator checking.
This will likely be the same case for other compositional operators applied to functions which should warn against "useless null checking".

@abonie abonie added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Needs-Triage labels Nov 25, 2024
@abonie abonie modified the milestones: Backlog, November-2024 Nov 25, 2024
@T-Gro T-Gro modified the milestones: November-2024, December-2024 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
Status: New
Development

No branches or pull requests

3 participants