Add FSharpCodeCompletionOptions

* Allows providing obsolete items
* Allows disabling override items
* Allows disabling pattern name suggestion items

Author: auduchinok

src/Compiler/Checking/AttributeChecking.fs

@@ -577,8 +577,10 @@ let CheckMethInfoAttributes g m tyargsOpt (minfo: MethInfo) =
 
 /// Indicate if a method has 'Obsolete', 'CompilerMessageAttribute' or 'TypeProviderEditorHideMethodsAttribute'. 
 /// Used to suppress the item in intellisense.
-let MethInfoIsUnseen g (m: range) (ty: TType) minfo = 
-    let isUnseenByObsoleteAttrib () = 
+let MethInfoIsUnseen g (m: range) (ty: TType) minfo allowObsolete = 
+    let isUnseenByObsoleteAttrib () =
+        if allowObsolete then false else
+
         match BindMethInfoAttributes m minfo 
                 (fun ilAttribs -> Some(CheckILAttributesForUnseen g ilAttribs m)) 
                 (fun fsAttribs -> Some(CheckFSharpAttributesForUnseen g fsAttribs m))

src/Compiler/Checking/AttributeChecking.fsi

@@ -77,7 +77,7 @@ val CheckILFieldAttributes: g: TcGlobals -> finfo: ILFieldInfo -> m: range -> un
 val CheckMethInfoAttributes:
     g: TcGlobals -> m: range -> tyargsOpt: 'a option -> minfo: MethInfo -> OperationResult<unit>
 
-val MethInfoIsUnseen: g: TcGlobals -> m: range -> ty: TType -> minfo: MethInfo -> bool
+val MethInfoIsUnseen: g: TcGlobals -> m: range -> ty: TType -> minfo: MethInfo -> allowObsolete: bool -> bool
 
 val PropInfoIsUnseen: m: 'a -> pinfo: PropInfo -> bool
 

src/Compiler/Checking/NameResolution.fs

@@ -913,10 +913,11 @@ val ResolveCompletionsInType:
     AccessorDomain ->
     bool ->
     TType ->
+    allowObsolete: bool ->
         Item list
 
 val GetVisibleNamespacesAndModulesAtPoint:
-    NameResolver -> NameResolutionEnv -> FullyQualifiedFlag -> range -> AccessorDomain -> ModuleOrNamespaceRef list
+    NameResolver -> NameResolutionEnv -> FullyQualifiedFlag -> range -> AccessorDomain -> allowObsolete: bool -> ModuleOrNamespaceRef list
 
 val IsItemResolvable: NameResolver -> NameResolutionEnv -> range -> AccessorDomain -> string list -> Item -> bool
 

src/Compiler/Checking/NameResolution.fsi

@@ -245,6 +245,14 @@ type public FSharpParsingOptions =
     static member internal FromTcConfigBuilder:
         tcConfigB: TcConfigBuilder * sourceFiles: string[] * isInteractive: bool -> FSharpParsingOptions
 
+type public FSharpCodeCompletionOptions =
+    { SuggestPatternNames: bool
+      SuggestObsoleteSymbols: bool
+      SuggestGeneratedOverrides: bool
+      SuggestOverrideBodies: bool }
+
+    static member Default: FSharpCodeCompletionOptions
+
 /// A handle to the results of CheckFileInProject.
 [<Sealed>]
 type public FSharpCheckFileResults =
@@ -293,8 +301,8 @@ type public FSharpCheckFileResults =
     /// <param name="completionContextAtPos">
     ///    Completion context for a particular position computed in advance.
     /// </param>
-    /// <param name="genBodyForOverriddenMeth">
-    ///    A switch to determine whether to generate a default implementation body for overridden method when completing.
+    /// <param name="options">
+    ///    Options to allow customizing behavior by an IDE.
     /// </param>
     member GetDeclarationListInfo:
         parsedFileResults: FSharpParseFileResults option *
@@ -303,7 +311,7 @@ type public FSharpCheckFileResults =
         partialName: PartialLongName *
         ?getAllEntities: (unit -> AssemblySymbol list) *
         ?completionContextAtPos: (pos * CompletionContext option) *
-        ?genBodyForOverriddenMeth: bool ->
+        ?options: FSharpCodeCompletionOptions ->
             DeclarationListInfo
 
     /// <summary>Get the items for a declaration list in FSharpSymbol format</summary>
@@ -324,16 +332,16 @@ type public FSharpCheckFileResults =
     /// <param name="getAllEntities">
     ///    Function that returns all entities from current and referenced assemblies.
     /// </param>
-    /// <param name="genBodyForOverriddenMeth">
-    ///    A switch to determine whether to generate a default implementation body for overridden method when completing.
+    /// <param name="options">
+    ///    Options to allow customizing behavior by an IDE.
     /// </param>
     member GetDeclarationListSymbols:
         parsedFileResults: FSharpParseFileResults option *
         line: int *
         lineText: string *
         partialName: PartialLongName *
         ?getAllEntities: (unit -> AssemblySymbol list) *
-        ?genBodyForOverriddenMeth: bool ->
+        ?options: FSharpCodeCompletionOptions ->
             FSharpSymbolUse list list
 
     /// <summary>Compute a formatted tooltip for the given keywords</summary>

src/Compiler/Service/FSharpCheckerResults.fs

@@ -125,8 +125,8 @@ module CheckResultsExtensions =
         member this.GetTooltip(context: ResolveContext, width) =
             this.GetToolTip(context.Pos.Line, context.Pos.Column, context.LineText, context.Names, FSharpTokenTag.Identifier, width)
 
-        member this.GetCodeCompletionSuggestions(context: CodeCompletionContext, parseResults: FSharpParseFileResults) =
-            this.GetDeclarationListInfo(Some parseResults, context.Pos.Line, context.LineText, context.PartialIdentifier)
+        member this.GetCodeCompletionSuggestions(context: CodeCompletionContext, parseResults: FSharpParseFileResults, options: FSharpCodeCompletionOptions) =
+            this.GetDeclarationListInfo(Some parseResults, context.Pos.Line, context.LineText, context.PartialIdentifier, options = options)
 
 [<RequireQualifiedAccess>]
 module Checker =
@@ -152,10 +152,13 @@ module Checker =
         let _, checkResults = getParseAndCheckResults context.Source
         context, checkResults
 
-    let getCompletionInfo (markedSource: string) =
+    let getCompletionInfoWithOptions (options: FSharpCodeCompletionOptions) (markedSource: string) =
         let context = getCompletionContext markedSource
         let parseResults, checkResults = getParseAndCheckResults context.Source
-        checkResults.GetCodeCompletionSuggestions(context, parseResults)
+        checkResults.GetCodeCompletionSuggestions(context, parseResults, options)
+
+    let getCompletionInfo markedSource =
+        getCompletionInfoWithOptions FSharpCodeCompletionOptions.Default markedSource
 
     let getSymbolUses (markedSource: string) =
         let context, checkResults = getCheckedResolveContext markedSource