From 0bdbc3705ddb90237e69d7b0422ea7880b6c705f Mon Sep 17 00:00:00 2001 From: allmhuran Date: Tue, 7 Jul 2020 21:54:36 +1000 Subject: [PATCH 1/2] Update SqlFacetAttribute.xml Document implies SqlFacets can only be used with return types. But they can also be used with input parameters. --- xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml b/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml index 0e5d1964b6f..1391b5752f7 100644 --- a/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml +++ b/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml @@ -32,7 +32,9 @@ may only be specified on non-void return values. + may only be specified on non-void return values, or on input parameters. + + to specify the on an input parameter, add the decoration inline with the parameter. is used only to derive information about the return type, and is not intended to be a constraint specification on what can be stored in the type. Thus, if a field has a indicating its size to be 2 characters, then the SQL Server type of the field access expression is of size 2, but assignments into the field are not restricted by this facet. From 1a791afb3f0a6a3bf916930135dd8493dc77c40c Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Tue, 9 May 2023 08:06:50 -0700 Subject: [PATCH 2/2] Apply suggestions from code review --- xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml b/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml index 1391b5752f7..73565cc1e75 100644 --- a/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml +++ b/xml/Microsoft.SqlServer.Server/SqlFacetAttribute.xml @@ -32,9 +32,9 @@ may only be specified on non-void return values, or on input parameters. + can only be specified on non-void return values or on input parameters. - to specify the on an input parameter, add the decoration inline with the parameter. +To specify the on an input parameter, add the decoration inline with the parameter. is used only to derive information about the return type, and is not intended to be a constraint specification on what can be stored in the type. Thus, if a field has a indicating its size to be 2 characters, then the SQL Server type of the field access expression is of size 2, but assignments into the field are not restricted by this facet.