Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: Http logging in dotnet 8 doesn't work without call AddHttpLogging #44532

Open
1 of 3 tasks
denisbredikhin opened this issue Jan 27, 2025 · 0 comments
Open
1 of 3 tasks
Assignees
Labels
breaking-change Indicates a .NET Core breaking change okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@denisbredikhin
Copy link

denisbredikhin commented Jan 27, 2025

Description

There is an behavioral breaking change in .NET 8: Http logging doesn't work without call AddHttpLogging.
It was discussed here: dotnet/aspnetcore#51322
Main documentation has been updated, but this change is not mentioned in the "Breaking changes in .NET 8" article.

Version

.NET 8

Previous behavior

It was enough to call app.UseHttpLogging(); to have HTTP logging activated.

New behavior

You need to call services.AddHttpLogging() too, otherwise your service crashes.

Type of breaking change

  • Binary incompatible: Existing binaries might encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
  • Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code might require source changes to compile successfully.
  • Behavioral change: Existing binaries might behave differently at run time.

Reason for change

dotnet/aspnetcore#50163

Recommended action

Please update "Breaking changes in .NET 8" article.

Feature area

ASP.NET Core

Affected APIs

No response


Associated WorkItem - 370661

@denisbredikhin denisbredikhin added the breaking-change Indicates a .NET Core breaking change label Jan 27, 2025
@dotnet-policy-service dotnet-policy-service bot added the ⌚ Not Triaged Not triaged label Jan 27, 2025
@CamSoper CamSoper added okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. and removed ⌚ Not Triaged Not triaged labels Feb 5, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Feb 5, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Feb 5, 2025
@CamSoper CamSoper added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Feb 5, 2025
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates a .NET Core breaking change okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
Development

No branches or pull requests

2 participants