Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example "Resilience with static clients" not using static HttpClient #44531

Closed
eakoning opened this issue Jan 27, 2025 · 0 comments · Fixed by #45026
Closed

Example "Resilience with static clients" not using static HttpClient #44531

eakoning opened this issue Jan 27, 2025 · 0 comments · Fixed by #45026
Assignees
@gewarren
Labels
dotnet-fundamentals/svc in-pr This issue will be closed (fixed) by an active pull request. 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@eakoning
Copy link

eakoning commented Jan 27, 2025 •
edited by sequestor bot
Loading

Type of issue

Other (describe below)

Description

The paragraph Resilience with static clients suggests a static HttpClient is created as per one of the two recommended approaches stated in the docs but that's not what the example shows.

[Enter feedback here]

Page URL

https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines

Content source URL

https://github.com/dotnet/docs/blob/main/docs/fundamentals/networking/http/httpclient-guidelines.md

Document Version Independent Id

3b1dd30f-82a8-2526-bd51-fb6401c52e81

Article author

@gewarren

Metadata

  • ID: 1a42e9c6-2624-e047-ed1c-03ec047b538a
  • Service: dotnet-fundamentals

Related Issues

Associated WorkItem - 368769
@dotnet-policy-service dotnet-policy-service bot added the ⌚ Not Triaged Not triaged label Jan 27, 2025
@gewarren gewarren self-assigned this Feb 3, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Feb 3, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Feb 3, 2025
@gewarren gewarren added 🗺️ reQUEST Triggers an issue to be imported into Quest. 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. labels Feb 3, 2025
@dotnet-policy-service dotnet-policy-service bot removed 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. ⌚ Not Triaged Not triaged labels Feb 3, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Feb 3, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Feb 3, 2025
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Feb 4, 2025
@gewarren gewarren moved this from 🔖 Ready to 👀 In review in dotnet/docs February 2025 sprint project Feb 25, 2025
@gewarren gewarren mentioned this issue Feb 25, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr This issue will be closed (fixed) by an active pull request. label Feb 25, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs February 2025 sprint project Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gewarren gewarren

Labels
dotnet-fundamentals/svc in-pr This issue will be closed (fixed) by an active pull request. 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
dotnet/docs February 2025 sprint project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use static HttpClient gewarren/docs
2 participants
@eakoning @gewarren