Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments on !47334 #5051

Open
1 of 3 tasks
dougbu opened this issue Feb 21, 2025 · 3 comments
Open
1 of 3 tasks

Address comments on !47334 #5051

dougbu opened this issue Feb 21, 2025 · 3 comments
Assignees
Labels
Ops - Facilely Operations issues that are easily accomplished or attained Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports

Comments

@dougbu
Copy link
Member

dougbu commented Feb 21, 2025

received a few comments in !47334 reviews to address in a follow-up PR:

  1. change linux-helixbot-is-1000.sh to silently succeed if there's no existing user w/ UID 1000. it'll error after we merge !47334
  2. remove duplicates between devtime_python_requirements.txt and runtime_python_requirements.txt. we don't use devtime_python_requirements.txt on its own
  3. improve linux-helixbot-is-1000/validate.sh error message to make expected UID clear
  4. correct a typo / misspelling in a dockerhelper.py comment

will also make a minor change in dockerhelper.py to do a more thorough job checking for an existing $HELIX_SCRIPTS_ROOT entry in $PYTHONPATH and update pipeline YAML to avoid potential errors and warnings

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

touched up earlier work done in !47334. none of this should impact customers at all

@dougbu dougbu self-assigned this Feb 21, 2025
@dougbu dougbu added Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports Ops - Facilely Operations issues that are easily accomplished or attained labels Feb 21, 2025
@dougbu
Copy link
Member Author

dougbu commented Feb 21, 2025

full list of changes go a bit further:

  • change linux-helixbot-is-1000.sh to normally succeed if there's no existing user w/ UID 1000
    • still create helixbot user in this case for consistency
  • remove devtime_python_requirements.txt / runtime_python_requirements.txt duplicates
    • go beyond psutil b/c more duplicates existed
    • reorder our python -m pip install commands to use devtime_python_requirements second
  • update dockerhelper.py to use grep -E and set $PYTHONPATH unconditionally
    • match regular expressions correctly
    • $HELIX_SCRIPT_ROOT will frequently have newer helix-scripts/ version than venv
  • make Validate_EndToEnd log file upload conditional in PR builds
    • avoid a potential build error when nothing is tested
  • add $(buildArch) to Validate_EndToEnd log artifact name in CI builds
    • also checkout self in post-job validation
    • avoid potential build errors and warnings
  • nits:
    • improve linux-helixbot-is-1000/validate.sh error message to make expected UID clear
    • correct a typo / misspelling in a dockerhelper.py comment
    • add azure-devops requirement to helix.base.yaml
    • move twine requirement to devtime_python_requirements.txt
      • no need for a separate installation step in our pipelines
    • sort requirements files
      • no real changes in runtime_python_requirements.txt
    • remove outdated virtualenv and wheel requirements
    • mark Validate as a validation job

@dougbu
Copy link
Member Author

dougbu commented Feb 21, 2025

fixed in !47851

@dougbu
Copy link
Member Author

dougbu commented Feb 21, 2025

additional fixes in !47826, !47827, and !47842 were done first due to CI build breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ops - Facilely Operations issues that are easily accomplished or attained Ops - Service Maintenance Used to track issues related to maintaining the services .NET Eng Supports
Projects
None yet
Development

No branches or pull requests

1 participant