Multiple value of Option

[WojciechNagorski]

I'm trying to switch BenchmarkDotNet (dotnet/BenchmarkDotNet#1016) to System.CommandLine.

But I have one problem. Currently BenchmarkDotNet uses multiple value of argument e.g.:
dotnet run -c Release -- --runtimes net472 netcoreapp2.1
or
--filter *ClassA* *ClassB*

Currently System.CommandLine doesn't support this. When I configure option:

   Option Filter() => new Option(new[] { "-r", "--runtimes" },
        "Full target framework moniker for .NET Core and .NET. For Mono just 'Mono', for CoreRT just 'CoreRT'. First one will be marked as baseline!",
        new Argument<string[]>());

I have to repeat an alias for each parameter value, like this:
--runtimes net472 --runtimes netcoreapp2.1

The worst scenario, instead:
--filter *ClassA* *ClassB* --runtimes net472 netcoreapp2.1 --exporters GitHub StackOverflow RPlot CSV JSON HTML XML --attribute Attribute1 Attribute2
we should type this:
--filter *ClassA* --filter *ClassB* --runtimes net472 --runtimes netcoreapp2.1 --exporters GitHub --exporters StackOverflow --exporters RPlot --exporters CSV --exporters JSON --exporters HTML --exporters XML --attribute Attribute1 --attribute Attribute2
This example doesn't contain other attributes that can have one value.

There is unit test that shows it doesn't work

command-line-api/src/System.CommandLine.Tests/ParserTests.cs

Lines 570 to 578 in 4f3b654

	[InlineData("--one 1 --many 1 --many 2")]
	[InlineData("--one 1 --many 1 --many 2 arg1 arg2")]
	[InlineData("--many 1 --one 1 --many 2")]
	[InlineData("--many 2 --many 1 --one 1")]
	[InlineData("--many:2 --many=1 --one 1")]
	[InlineData("[parse] --one 1 --many 1 --many 2")]
	[InlineData("--one \"stuff in quotes\" this-is-arg1 \"this is arg2\"")]
	[InlineData("not a valid command line --one 1")]
	public void Original_order_of_tokens_is_preserved_in_ParseResult_Tokens(string commandLine)

[WojciechNagorski]

If you would like to I can prepare PR which will change this behavior.

[jonsequitur]

I believe this is a duplicate of #368 and (with the difference of the delimiting character) #37.

If you would like to prepare a PR that would be great.

Just as a heads-up, this is related to #310.

[WojciechNagorski]

It is not duplicate. I don't want to split value. I want to pass many values with space between them. It is default behaviour of CommandLineParser library.

[jonsequitur]

I don't want to split value. I want to pass many values with space between them.

My understanding is that this is also the goal of #368. It has implications for both the parser (e.g. myapp --opt a b c parses a, b, and c as arguments to --opt assuming --opt has a minimum arity of at least 3), as well as for the binder (arguments a, b, and c can be bound to a single list parameter, e.g. List<string>, which is currently the behavior for example when you pass myapp --opt a --opt b --opt c).

Does this sound correct?

[WojciechNagorski]

I make PR #384. if there is still something to improve in this issue, please let me know.

[amis92]

I think since #384 is merged, the issue can be closed?