Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test coverage - validate arguments of public methods #7575

Open
wants to merge 127 commits into
base: main
Choose a base branch
from

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Feb 12, 2025

Initial issues #2649
Issues #5047
message

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

Added or Update public API test coverage for:

Components

  • Aspire.Azure.Ai.OpenAi
  • Aspire.Azure.Data.Tables
  • Aspire.Azure.Messaging.EventHubs
  • Aspire.Azure.Messaging.ServiceBus
  • Aspire.Azure.Messaging.WebPubSub
  • Aspire.Azure.Search.Documents
  • Aspire.Azure.Security.KeyVault
  • Aspire.Azure.Storage.Blobs
  • Aspire.Azure.Storage.Queues
  • Aspire.Confluent.Kafka
  • Aspire.Elastic.Clients.Elasticsearch
  • Aspire.Keycloak.Authentication
  • Aspire.Microsoft.Azure.Cosmos
  • Aspire.Microsoft.Data.Sql.Client
  • Aspire.Microsoft.EntityFrameworkCore.Cosmos
  • Aspire.Microsoft.EntityFrameworkCore.SqlServer
  • Aspire.Milvus.Client
  • Aspire.MongoDB.Driver
  • Aspire.MySqlConnector
  • Aspire.NATS.Net
  • Aspire.Confluent.Kafka
  • Aspire.Npgsql.EntityFrameworkCore.PostgreSQL
  • Aspire.Npgsql
  • Aspire.OpenAI
  • Aspire.Oracle.EntityFrameworkCore
  • Aspire.Pomelo.EntityFrameworkCore.MySql
  • Aspire.Qdrant.Client
  • Aspire.RabbitMQ.Client
  • Aspire.Seq
  • Aspire.StackExchange.Redis.DistributedCaching
  • Aspire.StackExchange.Redis.OutputCaching
  • Aspire.StackExchange.Redis

Hosting

  • Aspire.Hosting.Elasticsearch
  • Aspire.Hosting.Garnet
  • Aspire.Hosting.Kafka
  • Aspire.Hosting.Keycloak
  • Aspire.Hosting.Milvus
  • Aspire.Hosting.MongoDb
  • Aspire.Hosting.MySql
  • Aspire.Hosting.Nats
  • Aspire.Hosting.NodeJs
  • Aspire.Hosting.Python
  • Aspire.Hosting.Oracle
  • Aspire.Hosting.Redis
  • Aspire.Hosting.Qdrant
  • Aspire.Hosting.SqlServer
  • Aspire.Hosting.PosgreSql
  • Aspire.Hosting.RabbitMQ
  • Aspire.Hosting.Valkey
  • Aspire.Hosting.Testing

Other

  • Aspire.Extensions.Service.Discovery

Hosting.Azure

  • Aspire.Hosting.Azure.AppConfiguration
  • Aspire.Hosting.Azure.AppContainers
  • Aspire.Hosting.Azure.ApplicationInsights
  • Aspire.Hosting.Azure.CognitiveServices
  • Aspire.Hosting.Azure.CosmosDB

Need

  • [] Aspire.Hosting.Azure.* => Aspire.Hosting.Azure.Tests
Microsoft Reviewers: Open in CodeFlow

Zombach and others added 6 commits February 12, 2025 11:42
…ds#aspire-hosting-qdrant

update validate-arguments-of-public-methods#aspire-hosting-qdrant
…ds#aspire-hosting-redis

update validate-arguments-of-public-methods#aspire-hosting-redis
…ds#aspire-hosting-python

update validate-arguments-of-public-methods#aspire-hosting-python
@Zombach Zombach marked this pull request as draft February 12, 2025 18:56
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 12, 2025
Zombach and others added 22 commits February 12, 2025 23:38
…ds#aspire-hosting-testing

update validate-arguments-of-public-methods#aspire-hosting-testing
…ods#aspire-hosting-sql-server

update validate-arguments-of-public-methods#aspire-hosting-sql-server
…ods#aspire-hosting-rabbit-mq

update validate-arguments-of-public-methods#aspire-hosting-rabbit-mq
…ods#aspire-hosting-postgre-sql

update validate-arguments-of-public-methods#aspire-hosting-posgre-sql
…ods#aspire-hosting-node-js

update validate-arguments-of-public-methods#aspire-hosting-node-js
…ods#aspire-hosting-nats

update validate-arguments-of-public-methods#aspire-hosting-nats
…ods#aspire-hosting-my-sql

update validate-arguments-of-public-methods#aspire-hosting-my-sql
…ods#aspire-hosting-mongo-db

update validate-arguments-of-public-methods#aspire-hosting-mongo-db
…ods#aspire-hosting-milvus

update validate-arguments-of-public-methods#aspire-hosting-milvus
Zombach and others added 15 commits February 22, 2025 12:11
…ods#aspire-seq

update validate-arguments-of-public-methods#aspire-seq
…ods#aspire-stack-exchange-redis

update validate-arguments-of-public-methods#aspire-stack-exchange-redis
…ods#aspire-stack-exchange-redis-output-caching

update validate-arguments-of-public-methods#aspire-stack-exchange-redis-output-caching
…ods#aspire-stack-exchange-redis-distributed-caching

update validate-arguments-of-public-methods#aspire-stack-exchange-redis-distributed-caching
…ods#aspire-extensions-service-discovery

update validate-arguments-of-public-methods#aspire-extensions-service-discovery
…ods#aspire-oracle

update validate-arguments-of-public-methods#aspire-oracle
…ods#aspire-valkey

update validate-arguments-of-public-methods#aspire-valkey
@Zombach Zombach marked this pull request as ready for review February 22, 2025 15:50
@Zombach Zombach changed the title [DRAFT] Adding test coverage - validate arguments of public methods Adding test coverage - validate arguments of public methods Feb 22, 2025
@Zombach
Copy link
Contributor Author

Zombach commented Feb 22, 2025

@danmoseley I finished most of it. Probably can be checked and poured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant