We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
See the conversation at dotnet/eShop#759 (comment)
Today the Aspire integration enables OpenTelemetry unless someone disables tracing:
aspire/src/Components/Aspire.OpenAI/AspireOpenAIClientBuilderEmbeddingGeneratorExtensions.cs
Lines 59 to 61 in 3d3ccd4
but diffing this code with what's in UseOpenTelemetry(), maybe we need to update it to pass an ILogger in:
UseOpenTelemetry()
https://github.com/dotnet/extensions/blob/576fa221f57f80423a4852e446cee2aa2e937aab/src/Libraries/Microsoft.Extensions.AI/Embeddings/OpenTelemetryEmbeddingGeneratorBuilderExtensions.cs#L36-L43
loggerFactory ??= services.GetService<ILoggerFactory>(); var generator = new OpenTelemetryEmbeddingGenerator<TInput, TEmbedding>( innerGenerator, loggerFactory?.CreateLogger(typeof(OpenTelemetryEmbeddingGenerator<TInput, TEmbedding>)), sourceName); configure?.Invoke(generator); return generator;
That way someone doesn't need to call UseLogging().
UseLogging()
The text was updated successfully, but these errors were encountered:
Update OpenAI integration to pass an ILogger to OpenTelemetry clients
eab4380
Fix dotnet#7771
Successfully merging a pull request may close this issue.
See the conversation at dotnet/eShop#759 (comment)
Today the Aspire integration enables OpenTelemetry unless someone disables tracing:
aspire/src/Components/Aspire.OpenAI/AspireOpenAIClientBuilderEmbeddingGeneratorExtensions.cs
Lines 59 to 61 in 3d3ccd4
but diffing this code with what's in
UseOpenTelemetry()
, maybe we need to update it to pass an ILogger in:https://github.com/dotnet/extensions/blob/576fa221f57f80423a4852e446cee2aa2e937aab/src/Libraries/Microsoft.Extensions.AI/Embeddings/OpenTelemetryEmbeddingGeneratorBuilderExtensions.cs#L36-L43
That way someone doesn't need to call
UseLogging()
.The text was updated successfully, but these errors were encountered: