Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide limit reached messages on remove #7782

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 26, 2025

Description

Fixes #7747

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

playground/Stress/Stress.ApiService/Program.cs:110

  • Confirm that increasing the batch size from 10 to 100 will not unintentionally overload the logging subsystem or alter the expected batching behavior in production scenarios.
const int BatchSize = 100;

src/Aspire.Dashboard/Otlp/Storage/TelemetryRepository.cs:413

  • Verify that '_logs.IsFull' reliably represents the completeness of the logs collection at the time of paging; any timing or synchronization issues may result in an inconsistent presentation of log data.
return OtlpHelpers.GetItems(results, context.StartIndex, context.Count, _logs.IsFull);

playground/Stress/Stress.ApiService/TraceCreator.cs:35

  • Changing the method signature to require a 'traceName' parameter is clear, but please ensure that all consumers of this API are updated accordingly to avoid runtime errors.
public async Task CreateTraceAsync(string traceName, int count, bool createChildren, string? rootName = null)

src/Aspire.Dashboard/Otlp/Model/OtlpHelpers.cs:404

  • The new overload now requires an explicit 'isFull' parameter; double-check that all call sites are correctly passing the intended fullness status to maintain consistent paging behavior.
public static PagedResult<T> GetItems<T>(IEnumerable<T> results, int startIndex, int count, bool isFull)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After clearing telemetry the exceeded structured log limit warning still shows up
1 participant