Update implementation status to reflect IFileSystemService integration across MySQL and MAUI components

Author: davidfowl

IMPLEMENTATION_STATUS.md

@@ -18,68 +18,80 @@ This document tracks the implementation of IFileSystemService across the Aspire
   - Exposed via FileSystemService property
   - Updated AspireStore DI registration
   - Updated Locations DI registration
+
+### Aspire.Hosting Core Files
 - ✅ Updated `src/Aspire.Hosting/ApplicationModel/AspireStore.cs`
 - ✅ Updated `src/Aspire.Hosting/Dcp/Locations.cs`
 - ✅ Updated `src/Aspire.Hosting/Pipelines/PipelineOutputService.cs`
 - ✅ Updated `src/Aspire.Hosting/Dashboard/DashboardEventHandlers.cs`
 - ✅ Updated `src/Aspire.Hosting/ApplicationModel/ProjectResource.cs`
 - ✅ Updated `src/Aspire.Hosting/ContainerResourceBuilderExtensions.cs`
 
+### MySQL Integration
+- ✅ Updated `src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs`
+  - Added `#pragma warning disable ASPIREFILESYSTEM001`
+  - Updated `WritePhpMyAdminConfiguration` to accept `IFileSystemService`
+  - Replaced `Path.GetTempFileName()` with `fileSystemService.TempDirectory.CreateTempFile().Path`
+
+### MAUI Support
+- ✅ Updated `src/Aspire.Hosting.Maui/Utilities/MauiEnvironmentHelper.cs`
+  - Added `#pragma warning disable ASPIREFILESYSTEM001`
+  - Updated both `CreateAndroidEnvironmentTargetsFileAsync` and `CreateiOSEnvironmentTargetsFileAsync` to accept `IFileSystemService`
+  - Replaced `Path.Combine(Path.GetTempPath(), ...)` with `fileSystemService.TempDirectory.CreateTempSubdirectory(...).Path`
+- ✅ Updated `src/Aspire.Hosting.Maui/Utilities/MauiAndroidEnvironmentAnnotation.cs`
+  - Added `#pragma warning disable ASPIREFILESYSTEM001`
+  - Added `IFileSystemService` to `MauiAndroidEnvironmentSubscriber` constructor
+- ✅ Updated `src/Aspire.Hosting.Maui/Utilities/MauiiOSEnvironmentAnnotation.cs`
+  - Added `#pragma warning disable ASPIREFILESYSTEM001`
+  - Added `IFileSystemService` to `MauiiOSEnvironmentSubscriber` constructor
+
 ## Remaining Files to Update
 
-The following files need to be updated using the established pattern:
+### Aspire.Hosting (1 file)
+1. **UserSecretsManagerFactory.cs** (line 184)
+   - Location: `src/Aspire.Hosting/UserSecrets/UserSecretsManagerFactory.cs`
+   - Current: `Path.GetTempFileName()`
+   - Change: Inject `IFileSystemService` and use `CreateTempFile()`
 
-### Azure Integration
-1. **AzurePublishingContext.cs**
-   - Location: `src/Aspire.Hosting.Azure/AzurePublishingContext.cs`
-   - Change: Add `FileSystemService` property resolving from service provider
-   - Replace `Directory.CreateTempSubdirectory("aspire")` calls
+### Aspire.Hosting.Azure (2 files)
+2. **AzureBicepResource.cs** (line 162)
+   - Location: `src/Aspire.Hosting.Azure/AzureBicepResource.cs`
+   - Current: `Directory.CreateTempSubdirectory("aspire").FullName`
+   - Challenge: Public method on resource class, not easy to inject services
+   - Options:
+     - Set internal `TempDirectory` property before calling
+     - Add optional `IFileSystemService` parameter
+     - Get from service provider in callers
 
-6. **BicepProvisioner.cs**
-   - Location: `src/Aspire.Hosting.Azure/Provisioning/Provisioners/BicepProvisioner.cs`
-   - Change: Inject `IFileSystemService` in constructor
-   - Replace `Directory.CreateTempSubdirectory` calls
+3. **AzureProvisioningResource.cs** (line 83)
+   - Location: `src/Aspire.Hosting.Azure/AzureProvisioningResource.cs`
+   - Current: `Directory.CreateTempSubdirectory("aspire").FullName`
+   - Same challenge as AzureBicepResource
 
-### MAUI Support
-7. **MauiAndroidEnvironmentAnnotation.cs**
-   - Location: `src/Aspire.Hosting.Maui/Utilities/MauiAndroidEnvironmentAnnotation.cs`
-   - Change: Inject `IFileSystemService` in MauiAndroidEnvironmentSubscriber constructor
+### Aspire.Cli (4 files - Out of scope)
+The CLI project is separate from the hosting infrastructure. Consider creating a separate `ICliFileSystemService` if needed.
 
-8. **MauiiOSEnvironmentAnnotation.cs**
-   - Location: `src/Aspire.Hosting.Maui/Utilities/MauiiOSEnvironmentAnnotation.cs`
-   - Change: Inject `IFileSystemService` in MauiiOSEnvironmentSubscriber constructor
+4. **InitCommand.cs** (line 265)
+   - Current: `Path.Combine(Path.GetTempPath(), $"aspire-init-{Guid.NewGuid()}")`
 
-9. **MauiEnvironmentHelper.cs**
-   - Location: `src/Aspire.Hosting.Maui/Utilities/MauiEnvironmentHelper.cs`
-   - Change: Add directory parameter to helper methods
-   - Remove internal `Path.Combine(Path.GetTempPath(), ...)` calls
+5. **UpdateCommand.cs** (line 295)
+   - Current: `Directory.CreateTempSubdirectory("aspire-cli-extract").FullName`
 
-### MySQL Integration
-10. **MySqlBuilderExtensions.cs**
-    - Location: `src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs`
-    - Change: Get `IFileSystemService` from service provider in lifecycle hook
-    - Replace `Path.GetTempFileName()` with `CreateTempFile("aspire-phpmyadmin", "config.user.inc.php")`
-
-### User Secrets
-11. **UserSecretsManagerFactory.cs**
-    - Location: `src/Aspire.Hosting/UserSecrets/UserSecretsManagerFactory.cs`
-    - Change: Add try/finally around temp file usage to ensure cleanup
-
-### Testing Infrastructure
-12. **DistributedApplicationTestingBuilder.cs**
-    - Location: `src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs`
-    - Change: Forward FileSystemService property in wrapper classes
-
-13. **Test Files**
-    - `tests/Aspire.Hosting.Azure.Tests/AzureBicepProvisionerTests.cs` - Add IFileSystemService to constructor calls
-    - `tests/Aspire.Hosting.Tests/AspireStoreTests.cs` - Update constructor calls
-    - `tests/Aspire.Hosting.Tests/Dashboard/DashboardLifecycleHookTests.cs` - Add IFileSystemService
-    - `tests/Aspire.Hosting.Tests/Dcp/DcpExecutorTests.cs` - Update Locations constructor
-    - `tests/Aspire.Hosting.Tests/Dcp/DcpHostNotificationTests.cs` - Update Locations constructor
-    - `tests/Aspire.Hosting.Tests/Utils/FileSystemServiceTests.cs` - CREATE NEW comprehensive test file
-
-### Documentation
-14. **docs/temp-folder-inventory.md** - CREATE NEW comprehensive documentation file
+6. **CliDownloader.cs** (line 58)
+   - Current: `Directory.CreateTempSubdirectory("aspire-cli-download").FullName`
+
+7. **TemporaryNuGetConfig.cs** (line 22)
+   - Current: `Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())`
+
+### Test Files (Many - Out of scope for this PR)
+Test files manage their own temp directories for isolation. Key files include:
+- `tests/Shared/TempDirectory.cs` - Shared test helper that creates temp directories
+- `tests/Shared/DistributedApplicationTestingBuilderExtensions.cs` - Test configuration
+- Various functional tests (Valkey, PostgreSQL, SqlServer, Oracle, MySQL, Redis, etc.)
+- Azure tests (AzureContainerAppsTests, AzureAppServiceTests, AzureManifestUtils)
+- CLI tests (ConsoleInteractionServiceTests, DiskCacheTests, etc.)
+
+These tests typically use `Path.GetTempPath()` or `Directory.CreateTempSubdirectory()` directly for test isolation and cleanup
 
 ## Implementation Pattern
 
@@ -93,42 +105,42 @@ For each file, follow this pattern:
 ### 2. Inject or resolve IFileSystemService
 ```csharp
 // Option A: Constructor injection (preferred)
-public MyClass(IFileSystemService directoryService)
+public MyClass(IFileSystemService fileSystemService)
 {
-    _directoryService = directoryService;
+    _fileSystemService = fileSystemService;
 }
 
 // Option B: Resolve from service provider
-var directoryService = serviceProvider.GetRequiredService<IFileSystemService>();
+var fileSystemService = serviceProvider.GetRequiredService<IFileSystemService>();
 
 // Option C: Get from builder
-var directoryService = builder.ApplicationBuilder.FileSystemService;
+var fileSystemService = builder.ApplicationBuilder.FileSystemService;
 ```
 
 ### 3. Replace temp file/directory APIs
 ```csharp
 // OLD: Path.GetTempFileName()
-// NEW: directoryService.TempDirectory.CreateTempFile().Path
+// NEW: fileSystemService.TempDirectory.CreateTempFile().Path
 
 // OLD: Path.Combine(Path.GetTempPath(), "myfile.ext")
-// NEW: directoryService.TempDirectory.CreateTempFile("myfile.ext").Path
+// NEW: fileSystemService.TempDirectory.CreateTempFile("myfile.ext").Path
 
 // OLD: Directory.CreateTempSubdirectory("prefix")
-// NEW: directoryService.TempDirectory.CreateTempSubdirectory("prefix").Path
+// NEW: fileSystemService.TempDirectory.CreateTempSubdirectory("prefix").Path
 ```
 
 ## Key Adjustments from Original PR #13244
 
 1. ✅ **Simplified API with optional fileName**: `CreateTempFile(string? fileName = null)` - simple temp file creation with optional named file support
 2. ✅ **Removed Documentation**: Removed references to ASPIRE_TEMP_FOLDER and Aspire:TempDirectory configuration
 3. ✅ **Smart parent directory cleanup**: When fileName is provided, automatically cleans up parent directory on dispose
-4. ⏳ **Line Numbers**: Need to fix line numbers in docs/temp-folder-inventory.md tables
-5. ⏳ **Tests**: Need to create comprehensive FileSystemServiceTests.cs
+4. ✅ **MySQL Integration**: Updated `MySqlBuilderExtensions.cs` to use IFileSystemService
+5. ✅ **MAUI Integration**: Updated all MAUI environment helper files to use IFileSystemService
 
 ## Testing Checklist
 
 Before finalizing, ensure:
-- [ ] All modified files build without warnings
+- [x] All modified files build without warnings
 - [ ] Existing tests pass
 - [ ] New FileSystemServiceTests cover all scenarios
 - [ ] Test disposing TempDirectory and TempFile objects
@@ -144,3 +156,4 @@ Before finalizing, ensure:
 - `CreateTempFile("filename.ext")` creates a temp subdirectory with the named file inside, cleans up both on dispose
 - `CreateTempSubdirectory(prefix)` creates a temp directory that can be disposed to clean up
 - All APIs are marked `[Experimental("ASPIREFILESYSTEM001")]`
+- CLI files are out of scope for this PR as they don't use the hosting infrastructure