From 45af26aa5f10d91f2a9219505c5ede0bef4f8e18 Mon Sep 17 00:00:00 2001
From: Tim <cassell.timothy@gmail.com>
Date: Sat, 21 Dec 2024 21:06:07 -0500
Subject: [PATCH] Removed unnecessary output path properties from csproj
 templates.

---
 src/BenchmarkDotNet/Templates/CsProj.txt                        | 2 --
 src/BenchmarkDotNet/Templates/MonoAOTLLVMCsProj.txt             | 1 -
 src/BenchmarkDotNet/Templates/WasmCsProj.txt                    | 1 -
 src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs        | 1 -
 .../Toolchains/MonoAotLLVM/MonoAotLLVMGenerator.cs              | 1 -
 src/BenchmarkDotNet/Toolchains/MonoWasm/WasmGenerator.cs        | 1 -
 6 files changed, 7 deletions(-)

diff --git a/src/BenchmarkDotNet/Templates/CsProj.txt b/src/BenchmarkDotNet/Templates/CsProj.txt
index 5cd08250dc..c93398f11e 100644
--- a/src/BenchmarkDotNet/Templates/CsProj.txt
+++ b/src/BenchmarkDotNet/Templates/CsProj.txt
@@ -9,7 +9,6 @@
     <PlatformTarget>$PLATFORM$</PlatformTarget>
     <AssemblyName>$PROGRAMNAME$</AssemblyName>
     <OutputType>Exe</OutputType>
-    <OutputPath>bin\$CONFIGURATIONNAME$</OutputPath>
     <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
     <!-- Usage of System.Random can cause compilation errors if Code Analysis warnings are treated as Errors -->
     <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
@@ -23,7 +22,6 @@
     <Optimize Condition=" '$(Configuration)' != 'Debug' ">true</Optimize>
     <!-- we set LangVersion after any copied settings which might contain LangVersion copied from the benchmarks project -->
     <LangVersion Condition="'$(LangVersion)' == '' Or ($([System.Char]::IsDigit('$(LangVersion)', 0)) And '$(LangVersion)' &lt; '7.3')">latest</LangVersion>
-    <AppendTargetFrameworkToOutputPath>true</AppendTargetFrameworkToOutputPath>
     <!-- fix for NETSDK1150: https://docs.microsoft.com/en-us/dotnet/core/compatibility/sdk/5.0/referencing-executable-generates-error -->
     <ValidateExecutableReferencesMatchSelfContained>false</ValidateExecutableReferencesMatchSelfContained>
     <StartupObject>BenchmarkDotNet.Autogenerated.UniqueProgramName</StartupObject>
diff --git a/src/BenchmarkDotNet/Templates/MonoAOTLLVMCsProj.txt b/src/BenchmarkDotNet/Templates/MonoAOTLLVMCsProj.txt
index 1db40072d1..5bd84e9782 100644
--- a/src/BenchmarkDotNet/Templates/MonoAOTLLVMCsProj.txt
+++ b/src/BenchmarkDotNet/Templates/MonoAOTLLVMCsProj.txt
@@ -9,7 +9,6 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <OutputPath>bin</OutputPath>
     <TargetFramework>$TFM$</TargetFramework>
     <MicrosoftNetCoreAppRuntimePackDir>$RUNTIMEPACK$</MicrosoftNetCoreAppRuntimePackDir>
     <RuntimeIdentifier>$RUNTIMEIDENTIFIER$</RuntimeIdentifier>
diff --git a/src/BenchmarkDotNet/Templates/WasmCsProj.txt b/src/BenchmarkDotNet/Templates/WasmCsProj.txt
index e45f5c3789..272c14325c 100644
--- a/src/BenchmarkDotNet/Templates/WasmCsProj.txt
+++ b/src/BenchmarkDotNet/Templates/WasmCsProj.txt
@@ -11,7 +11,6 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <OutputPath>bin</OutputPath>
     <RuntimeConfig>Release</RuntimeConfig>
     <EnableDefaultCompileItems>false</EnableDefaultCompileItems>
     <TargetFramework>$TFM$</TargetFramework>
diff --git a/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs b/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
index 7e91c36ff4..c324f66b88 100644
--- a/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
+++ b/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
@@ -85,7 +85,6 @@ protected override void GenerateProject(BuildPartition buildPartition, Artifacts
                 .Replace("$PROGRAMNAME$", artifactsPaths.ProgramName)
                 .Replace("$RUNTIMESETTINGS$", GetRuntimeSettings(benchmark.Job.Environment.Gc, buildPartition.Resolver))
                 .Replace("$COPIEDSETTINGS$", customProperties)
-                .Replace("$CONFIGURATIONNAME$", buildPartition.BuildConfiguration)
                 .Replace("$SDKNAME$", sdkName)
                 .ToString();
 
diff --git a/src/BenchmarkDotNet/Toolchains/MonoAotLLVM/MonoAotLLVMGenerator.cs b/src/BenchmarkDotNet/Toolchains/MonoAotLLVM/MonoAotLLVMGenerator.cs
index de3cef53d3..0816ac48f0 100644
--- a/src/BenchmarkDotNet/Toolchains/MonoAotLLVM/MonoAotLLVMGenerator.cs
+++ b/src/BenchmarkDotNet/Toolchains/MonoAotLLVM/MonoAotLLVMGenerator.cs
@@ -43,7 +43,6 @@ protected override void GenerateProject(BuildPartition buildPartition, Artifacts
                 .Replace("$TFM$", TargetFrameworkMoniker)
                 .Replace("$PROGRAMNAME$", artifactsPaths.ProgramName)
                 .Replace("$COPIEDSETTINGS$", customProperties)
-                .Replace("$CONFIGURATIONNAME$", buildPartition.BuildConfiguration)
                 .Replace("$SDKNAME$", sdkName)
                 .Replace("$RUNTIMEPACK$", CustomRuntimePack ?? "")
                 .Replace("$COMPILERBINARYPATH$", AotCompilerPath)
diff --git a/src/BenchmarkDotNet/Toolchains/MonoWasm/WasmGenerator.cs b/src/BenchmarkDotNet/Toolchains/MonoWasm/WasmGenerator.cs
index 7c9aa8826f..c33642f6a9 100644
--- a/src/BenchmarkDotNet/Toolchains/MonoWasm/WasmGenerator.cs
+++ b/src/BenchmarkDotNet/Toolchains/MonoWasm/WasmGenerator.cs
@@ -57,7 +57,6 @@ protected void GenerateProjectFile(BuildPartition buildPartition, ArtifactsPaths
                 .Replace("$TFM$", TargetFrameworkMoniker)
                 .Replace("$PROGRAMNAME$", artifactsPaths.ProgramName)
                 .Replace("$COPIEDSETTINGS$", customProperties)
-                .Replace("$CONFIGURATIONNAME$", buildPartition.BuildConfiguration)
                 .Replace("$SDKNAME$", sdkName)
                 .Replace("$WASMDATADIR$", runtime.WasmDataDir)
                 .Replace("$TARGET$", CustomRuntimePack != null ? "PublishWithCustomRuntimePack" : "Publish")