You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Jobs with provided Ids pass along those Ids when modifications are made.
CsProj is always generated with the same filename BenchmarkDotNet.Autogenerated.csproj.
When --keepFiles is specified, the generated directory uses the job Id instead of a guid.
Combine those factors, and when you try something like this, the builds will be incorrect.
DefaultConfig.Instance
.AddJob(Job.ShortRun.WithRuntime(RuntimeMoniker.Net70.GetRuntime()))// Id is ShortRun.AddJob(Job.ShortRun.WithRuntime(RuntimeMoniker.NativeAot70.GetRuntime()))// Id is ShortRun.KeepBenchmarkFiles(true);
Orthogonally, I think the API is bad. Id is generally expected to be a unique identifier (or at least semi-unique), which is clearly not the case here. Ideally, the Id would be generated always internally, and we would only expose setting a Name rather than Id. But of course that would be a hefty breaking change.
The text was updated successfully, but these errors were encountered:
Jobs with provided Ids pass along those Ids when modifications are made.
CsProj is always generated with the same filename
BenchmarkDotNet.Autogenerated.csproj
.When
--keepFiles
is specified, the generated directory uses the job Id instead of a guid.Combine those factors, and when you try something like this, the builds will be incorrect.
Orthogonally, I think the API is bad.
Id
is generally expected to be a unique identifier (or at least semi-unique), which is clearly not the case here. Ideally, theId
would be generated always internally, and we would only expose setting aName
rather thanId
. But of course that would be a hefty breaking change.The text was updated successfully, but these errors were encountered: