Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort !gamemedals by top bar #307

Open
DatGuy1 opened this issue Apr 5, 2023 · 13 comments
Open

Sort !gamemedals by top bar #307

DatGuy1 opened this issue Apr 5, 2023 · 13 comments
Labels
bug Something isn't working

Comments

@DatGuy1
Copy link
Contributor

DatGuy1 commented Apr 5, 2023

Or, at the very least, by teams when applicable

@Geczy
Copy link
Member

Geczy commented Apr 11, 2023

we sort by medal on purpose since it seems like most people typing !gm just want to see who's highest and lowest. lmk if other streamers want otherwise though, maybe some polls to ask chat in certain streams to find out? can re-open then

thanks for opening your first issue!

@Geczy Geczy closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
@Geczy
Copy link
Member

Geczy commented Apr 11, 2023

splitting it up for radiant & dire isn't a bad idea actually

@Geczy Geczy reopened this Apr 16, 2023
@Geczy
Copy link
Member

Geczy commented Apr 16, 2023

opening cause did receive feedback that people want this too

@Geczy
Copy link
Member

Geczy commented Apr 17, 2023

one problem is that !gm in lower rank games consolidates like-ranked players. so it won't make sense to have it 1-10 order in those games

should it only order 1-10 in high ranked?

image

@Woody3797
Copy link

i think most people prefer listing out by individuals from left to right, it wont make the message much longer than it already is and its easier to read too imo. can do a poll to see what the people like

@DatGuy1
Copy link
Contributor Author

DatGuy1 commented Apr 20, 2023

The behaviour should definitely be consistent regardless of the rank. Either remove the merging altogether, or only merge them when they're sequential.

@Geczy
Copy link
Member

Geczy commented Apr 21, 2023

holy

image

@Geczy Geczy added this to Roadmap Jun 16, 2023
@github-project-automation github-project-automation bot moved this to 🏹 Coming up in Roadmap Jun 16, 2023
@Geczy Geczy added the bug Something isn't working label Aug 14, 2023
@Geczy
Copy link
Member

Geczy commented Sep 3, 2023

CleanShot 2023-09-03 at 13 36 58@2x

did another poll and the sentiment changed? 😂

@Woody3797
Copy link

hahahaha,i guess ppl are used to it now? still feel its easier to parse when it is in order, but can just keep it as it is,less code for u!

@DatGuy1
Copy link
Contributor Author

DatGuy1 commented Sep 4, 2023 via email

@Geczy
Copy link
Member

Geczy commented Sep 4, 2023

that pic was from gorgc's channel. i think there's some bug in twitch polls where not everyone can see it or something

i tried another sample today
50DF49D6-9E34-415A-9850-BBDC3092209A_1_102_o

@Woody3797
Copy link

would it be ok if u try putting it in hero top bar order for a while,and see the general feedback from there?

@Geczy
Copy link
Member

Geczy commented Sep 4, 2023

yeah of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏹 Coming up
Development

No branches or pull requests

3 participants