Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need indicator to user to differentiate between user-uploaded and Expression Database data #863

Open
kdahlquist opened this issue Apr 30, 2020 · 7 comments

Comments

@kdahlquist
Copy link
Collaborator

I see how the functionality works now. The user uploaded data and Expression Database data are both accessible from the drop-down menus, which is what we wanted.

However, there is no indicator to the user that this is the case. Also, our Expression Database is only for yeast right now.

We need to provide some more info to the user about this. I'm pretty braindead right now so I don't have any suggestions off the top of my head, but I wanted to note this as an issue.

@dondi dondi changed the title Need indicator to user to differentiate between user-uploaded and Expression Databae data Need indicator to user to differentiate between user-uploaded and Expression Database data Jan 9, 2024
@dondi
Copy link
Owner

dondi commented Jan 9, 2024

Possibly prepending text or looking into optgroup may make this low-hanging fruit

@ntran18
Copy link
Collaborator

ntran18 commented Nov 27, 2024

I think we need to sit down and think where to put it before I can implement anything 😅.

@kdahlquist
Copy link
Collaborator Author

There would be two optgroups:

  • User-uploaded
  • Expression Database

@kdahlquist kdahlquist assigned Amelie1253 and MilkaZek and unassigned ntran18 Feb 6, 2025
@MilkaZek
Copy link
Collaborator

We went through the various pages and identified this section (referring to the attached screenshot/code snippet) of the update-app.js file to be where we need to separate the drop-down menu options - we (@Amelie1253 and I) plan to attempt that fix this upcoming week after clarifying which list options fall under the category of User-uploaded or Expression Database.

Image

@Amelie1253
Copy link
Collaborator

When looking through the code, I found these comments and just wanted to bring it up

Image

.

@dondi
Copy link
Owner

dondi commented Feb 19, 2025

In response to this comment…

We went through the various pages and identified this section (referring to the attached screenshot/code snippet) of the update-app.js file to be where we need to separate the drop-down menu options - we (@Amelie1253 and I) plan to attempt that fix this upcoming week after clarifying which list options fall under the category of User-uploaded or Expression Database.

The code snapshot points to the right place; the values listed in line 714 should be what eventually gets wrapped in an opt-group labeled “User-uploaded” and the line 721 block is what gets wrapped in an “Expression database” opt-group

@dondi
Copy link
Owner

dondi commented Feb 19, 2025

For question regarding the long comment, that pertains to #865 —we have backlogged it because the workaround appears to remain stable and we haven’t had the bandwidth to investigate this further for a “real” solution

We can help future developers by cross-linking between this comment and the issue (i.e., mention the issue number in the comment, and perhaps in the issue, mention the file/approximate location of the workaround)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants